Patrick Jung

Results 21 comments of Patrick Jung

Any progress on this issue?

@TheAndroidMaster I guess I'll wait for your refactoring to be completed before giving this a try ;)

*Luckily the well implemented Unit- & UI-Tests advised you that there was something broken*

@TheAndroidMaster *I don't know lol.. You're the developer, not me /s*

@TheAndroidMaster well, it depends on how the app is actually splitted in terms of modularity. If it's not ready-for-testing this might be a bunch of refactoring work lol Maybe adding...

In case the Toolbar is wrapped into an `AppBarLayout` you've to set the elevation to the desired depth on the `AppBarLayout` to take affect

Hello. I was about to use this library.\ Unfortunately, I realized during debugging that interface/abstract class injection is not supported. W/o being able to resolve base classes from given implementations...

Any updates on this or something that can be helped out with to get it merged?

@therealrinku would you mind updating your MR so the pipelines do pass? The feature works quite well and I'm looking forward to having this in the main branch

@therealrinku thanks a lot for the update 👍 @helloanoop is there anything further required where I can assist you for this MR to be merged?