pcsx2 icon indicating copy to clipboard operation
pcsx2 copied to clipboard

GS:Mac: Add ffmpeg

Open TellowKrinkle opened this issue 2 years ago • 3 comments

Description of Changes

  • Adds a minimal (~3MB) copy of ffmpeg to Mac builds (includes a few small lossless codecs and the interface to macOS's system encoding libraries)
  • Fixes a bug where s16 codecs would get their audio mangled
  • Fixes a bug where setting a pixel format with pixel_format=fmt in the extra arguments would break things

Rationale behind Changes

Capture support on macOS

Suggested Testing Steps

Try recording things on macOS

TellowKrinkle avatar Jun 27 '23 09:06 TellowKrinkle

Tested on Windows and it works correctly it also fixes recording with FLAC cannot test on Mac OS.

JordanTheToaster avatar Jun 27 '23 13:06 JordanTheToaster

I'm getting "failed to find video encoder" errors on Mac regardless of what output file format I try (MOV, MKV, etc). Also, weirdly, it wanted to access my calendar. That's probably just Mac being stupid, I don't think we touch that on purpose.

Screenshot 2023-06-27 at 12 28 22 PM Screenshot 2023-06-27 at 12 28 44 PM

DigitalMajestic avatar Jun 27 '23 19:06 DigitalMajestic

I'm getting "failed to find video encoder" errors on Mac regardless of what output file format I try (MOV, MKV, etc)

Should be fixed now

Also, weirdly, it wanted to access my calendar. That's probably just Mac being stupid, I don't think we touch that on purpose.

Qt's file open/save dialog was touching it. Fixed in #9104 which I've rebased this on top of

TellowKrinkle avatar Jun 28 '23 05:06 TellowKrinkle

Permissions spam is fixed. Default encoders failing is not. Manually selecting the proper encoders works as expected.

DigitalMajestic avatar Jun 29 '23 07:06 DigitalMajestic

Permissions spam is fixed. Default encoders failing is not. Manually selecting the proper encoders works as expected.

Try now

TellowKrinkle avatar Jun 30 '23 03:06 TellowKrinkle