pcsx2 icon indicating copy to clipboard operation
pcsx2 copied to clipboard

Update AudioSettingsWidget.cpp

Open xujibbs opened this issue 1 year ago • 3 comments

Description of Changes

Rationale behind Changes

Suggested Testing Steps

xujibbs avatar Jun 25 '23 12:06 xujibbs

hmm I'm not sure what you've done here is right, that stuff is inside a QT_TRANSLATE_NOOP which I believe is supposed to be so it doesn't translate it on purpose (the comments suggest this too). I'm sure it needs to be done differently, I would check other dropdown menus for examples.

refractionpcsx2 avatar Jun 25 '23 13:06 refractionpcsx2

It needs to be done differently, and there is a confusion with the comments:

  • The words "Cubeb"/"Xaudio2" should not be translated, but the text inside the parentheses should, so those strings should be made translatable. The comments are for translators.

IlDucci avatar Jun 25 '23 15:06 IlDucci

Yup, this is incorrect. It might need a qApp->translate call later (although these strings should be declared in the core to begin with)

stenzek avatar Jun 25 '23 16:06 stenzek

Superseded by #9086.

stenzek avatar Jun 26 '23 11:06 stenzek