pcsx2 icon indicating copy to clipboard operation
pcsx2 copied to clipboard

[BUG]: Persona 4 - Menu SW Renderer Flickering

Open JWatersMeet opened this issue 2 years ago • 9 comments

Describe the Bug

Depending on the renderer selected, the color rendering of the Persona 4 UI changes. They can be put into three groups:

  • Vulkan and OpenGL

Vulkan Persona 4 - Vulkan

OpenGL Persona 4 - OpenGL

  • DX11 and DX12

DX11 Persona 4 - D3D11

DX12 Persona 4 - D3D12

  • Software (also has flickering)

Persona 4 - Software

https://github.com/PCSX2/pcsx2/assets/136824455/a7f3de0d-fce9-47e3-962d-d26ac1fbe61f

Reproduction Steps

  • Start Persona 4
  • Open Saves Menu
  • Switch Renderers

Expected Behavior

  • Color rendering should be consistent across all four.
  • Software should have no flickering.

PCSX2 Revision

1.7.4637

Operating System

Windows 11

If Linux - Specify Distro

No response

CPU

Ryzen 5900HX

GPU

RTX 3080 Mobile

GS Settings

None

Emulation Settings

None

GS Window Screenshots

No response

Logs & Dumps

Shin Megami Tensei - Persona 4_SLUS-21782_20230625100714

Shin Megami Tensei - Persona 4_SLUS-21782_20230625100714.zip

JWatersMeet avatar Jun 25 '23 09:06 JWatersMeet

SW is a bug, dx11/dx12 being different is likely blending and a limitation of the api.

stenzek avatar Jun 25 '23 10:06 stenzek

Yeah, can confirm it to be a blending issue. The game also need at least high blending (vulkan/openGL) to properly render the menu effects.

see: Basic blending Shin Megami Tensei - Persona 4_SLUS-21782_20230625185859

Shin Megami Tensei - Persona 4_SLUS-21782_20230625185852

High blending Shin Megami Tensei - Persona 4_SLUS-21782_20230625185729

Shin Megami Tensei - Persona 4_SLUS-21782_20230625185753

GS dumps (jus in case): Shin Megami Tensei - Persona 4_SLUS-21782_20230625185729.zip

Shin Megami Tensei - Persona 4_SLUS-21782_20230625185737.zip

Ir-boop avatar Jun 25 '23 11:06 Ir-boop

Well, that's quite weird. Software looks fine for me if I switch to it, but if I start with software, it alternates between colours.

Edit: Ugh, looks like a threading issue perhaps. It's fine with no extra threads...

stenzek avatar Jun 25 '23 11:06 stenzek

Well, that's quite weird. Software looks fine for me if I switch to it, but if I start with software, it alternates between colours.

Edit: Ugh, looks like a threading issue perhaps. It's fine with no extra threads...

Yeah, I try to run game from start with software rendering and the colour flickering happens. Weird is, if i move the saves selection the flickering gone. See:

https://github.com/PCSX2/pcsx2/assets/96909828/53e73a01-9ef2-4a27-9868-be69a9ceb3a1

With 0 extra threading it's not flickering but instead the colour is as if the blending is basic. However if i move the saves selection it's back to normal too.

Ir-boop avatar Jun 25 '23 12:06 Ir-boop

Been doing some work to try and identify where the regressions occurred.

  • Last known good build was 4541.
  • In 4542, the colors in Software Rendering have changed (parts become darker). Possibly #8906

4541 - Good Colors

4542 - Bad Colors

JWatersMeet avatar Jun 28 '23 10:06 JWatersMeet

#8934 doesn't sound like a correct bisect, because it only changed HW.

stenzek avatar Jun 28 '23 12:06 stenzek

Sure, I'll double check.

JWatersMeet avatar Jun 28 '23 12:06 JWatersMeet

Seems to be a bad bisect - looks like the issue is intermittent. I'll see if I can find a way to trigger it. I've removed the ref to the issue above until I've tracked it down.

JWatersMeet avatar Jun 28 '23 13:06 JWatersMeet

Right, the flickering started at the same time as the color change above (Build 4542) - it seems somtimes it doesn't flicker, just says on the darkened colors. If that happens, the flickering can be triggered by fiddling with the number of software rendering threads until it starts.

JWatersMeet avatar Jun 28 '23 13:06 JWatersMeet

Closed, no longer occurs in latest build. Have tried changing SW rendering threads, all good now.

JWatersMeet avatar Jul 14 '23 16:07 JWatersMeet

That's strange. I don't think anything was changed recently which would've affected it.. unless it was #9232

stenzek avatar Jul 14 '23 17:07 stenzek