pcsx2 icon indicating copy to clipboard operation
pcsx2 copied to clipboard

[BUG]: Meta thread for translations

Open IlDucci opened this issue 1 year ago • 32 comments

Describe the Bug

This is a new look made at the current state of PCSX2 localization and the issues that have appeared during the testing of the first PR that had languages included. It might affect both English texts and non-English. Might also be a master thread of sorts.

MAIN MENU

  • Menu bar -> Settings: Missing hotkeys for a number of options (UI, Game List, Emulation...)
  • Menu bar -> Overall missing hotkeys for a number of options
  • List view -> Issues with columns fixed width, columns should expand accordingly to match the translated text sizes (Last Played, Play Time...)
  • List view -> Dates in the Last Played section are stuck with the US English date format. These (and all dates) should reflect either the translation language or the system's internal values for date display.

SETTINGS WINDOW

  • Settings -> Game List -> Issues with columns fixed width, columns should expand accordingly to match the translated "Scan Recursively" text (has a dupe in the Setup Wizard).
  • Settings -> Emulation -> Frame Pacing/Latency Control: hook the "../Settings/EmulationSettingsWidget.ui:255" (" frames") string to QT's pluralization system.
  • Settings -> Graphics -> Rendering: all the Internal Resolution settings are untranslatable. Probably because they are in pcsx2-qt\Settings\GraphicsSettingsWidget.cpp and not in GraphicsSettingsWidget.ui.
  • Settings -> Graphics -> Rendering: all the Anisotropic Filter settings are untranslatable. Probably because they are in pcsx2-qt\Settings\GraphicsSettingsWidget.cpp and not in GraphicsSettingsWidget.ui.
  • Settings -> Graphics -> Post-Processing: CAS-related strings are missing (reported by @nikivarvar )
  • Settings -> Network and HDD -> Internal DNS -> the topmost hint is limited to one line. imagen
  • Settings -> Achievements -> Account -> Possible wontfix, but can the access token date be hooked into QT's localization for dates, or whatever it's called? imagen
  • Settings -> Achievements: shouldn't the lower text be justified to the left, like all the other texts, instead of being justified? imagen

CONTROLLERS WINDOW

  • Global Settings -> When enabling the "Profile Settings" option (by selecting a profile that is not the Shared one), the box squishes and no longer fits into expanded text. imagen
  • Controllers -> Macros -> Frequency: the "Macro will toggle buttons every %1 frames." should be hooked to QT's pluralization system.
  • Controllers -> Macros -> Edit Bindings subwindow: is it possible to translate "MacroX" and "PadX" in the string "Bindings for %1 %2"?

INPUT RECORDING

  • Input recording strings in Imgui are untranslatable.

DEBUGGER WINDOWS

  • Create / Modify Breakpoint: the entire window has a fixed size for English. This window should have an adaptable sizing for non-English languages. imagen

BIG PICTURE/ON-SCREEN MESSAGES/IMGUI

  • The dropdown option window is not suited for strings that are longer than the actual box itself (case in point: the Deinterlacing option window, as it has fairly long descriptions for each deinterlacing method). Is it possible to turn these cases into ticker texts? Make them scroll from left to right (or right to left for any language that requires it).
  • File Explorer -> All the strings are untranslatable.
    • Located at pcsx2\ImGui\ImGuiFullScreen.cpp.
  • Settings -> Graphic Settings -> Aspect Ratio -> All options are untranslatable.
  • Settings -> Graphic Settings -> FMV Aspect Ratio -> All options are untranslatable.
  • Settings -> Audio Settings -> Plenty of the new strings are untranslatable. Probably just needs a pass of the Python script to make them translatable.
  • Settings -> Controller Settings -> Macro X Buttons -> The "Trigger" label is still untranslatable, after my last failed attempt.
  • Settings -> Controller Settings -> Macro X Buttons -> Frequency -> Macro X Frequency window -> The "OK" button is untranslatable.
  • Settings -> Controller Settings -> Controller Port X Settings -> EVERY sublabel is untranslatable.
  • Settings -> Controller Settings -> Controller Port X Settings -> Invert Left Stick/Invert Right Stick -> A default config setting will display "Unknown" as the chosen option. An user right now has to pick an option again to get it properly displayed.
  • Settings -> Controller Settings -> Controller Port X Settings -> Invert Left Stick/Invert Right Stick -> All options are untranslatable.
  • Settings -> Controller Settings -> Controller Port X Settings -> All percentage values are untranslatable.
  • Settings -> Controller Settings -> USB Port X -> All device types are untranslatable, both in the dropdown window and in the sublabels.
  • Settings -> Controller Settings -> USB Port X -> The string "Not Connected" for a USB Port type is untranslatable.
  • Settings -> Controller Settings -> USB Port X -> GunCon 2 -> Cursor Path label is untranslatable.
  • Settings -> Controller Settings -> USB Port X -> (Device) Settings -> EVERY sublabel is untranslatable.
  • Settings -> Controller Settings -> USB Port X -> (Device) Settings -> All percentage/px values are untranslatable.
  • Game List -> List Mode -> Compatibility Rating names are untranslatable.
  • Game Properties -> Details -> Type -> Type names are untranslatable.
  • Game Properties -> Details -> Compatibility Rating -> Names are untranslatable.
  • Game Properties -> Patches -> Gray warning texts might require multiple lines or ticker animation support so longer translated lines can be properly displayed.
  • Game Properties -> Game Fixes -> Gray warning text might require multiple lines or ticker animation support so longer translated lines can be properly displayed.
  • On Screen Messages: substrings for the mismatch in Blending Accuracy are untranslatable.
    • Reference: https://github.com/PCSX2/pcsx2/blob/efae58de5267cf66e993efed265ef71c3e4c1346/pcsx2/GameDatabase.cpp#L888

COMPLETED:

OVERALL

  • ~~Overall: Some "Form" texts that should not be translatable have popped back up:~~
    • ~~../Settings/GameCheatSettingsWidget.ui:14~~
    • ~~../Settings/GamePatchDetailsWidget.ui:20~~
    • ~~../Settings/PatchDetailsWidget.ui:14~~
    • ~~../Settings/GamePatchSettingsWidget.ui:14~~
  • ~~Overall: Is it possible to remove from translations some of the most unwanted HTML codes? Like here: <!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.0//EN" "http://www.w3.org/TR/REC-html40/strict.dtd"> <html><head><meta name="qrichtext" content="1" /><meta charset="utf-8" /><style type="text/css">~~

MAIN MENU

  • ~~Main menu -> Toolbar: Decouple the toolbar strings from the rest so localized versions can try to shorten/abbreviate the toolbar buttons. (akin to what Dolphin does)~~

SETTINGS WINDOW

  • ~~Settings ->Interface -> Maybe change the "Language:" string so all non-English languages display instead "Language [in the destination language] (Language) [in English]:"?~~ Won't fix
  • ~~Settings -> Interface -> Theme -> All theme names have become untranslatable (they were translatable before, and even if there was a decision to not translate the names, the words within parentheses should be translatable). Spotted by @xujibbs .~~
  • ~~Settings -> Emulation -> System Settings: Decouple the "Disabled" string. So far I only see two copies (EE Cycle Skipping and Affinity Control), but there seems to be four?~~ Won't fix
  • ~~Settings -> Graphics -> Post-Processing: add a colon to "Saturation".~~
  • ~~Settings -> Graphics -> Post-Processing: the "Saturation:" string within the window is merged with the "Saturation" string of the description box, showing the colon there as well. This string needs deduplication. (reported by @nikivarvar )~~
  • ~~Settings -> Graphics -> Maybe decouple all the "None"/Auto" strings so genders/numbers can be customizable depending on the option?~~ Won't fix
  • ~~Settings -> Audio -> Expansion -> "quadrafonic" should be corrected to "quadraphonic" (reported by @piorrro33 )~~ SECTION REDESIGNED, FIXED
  • ~~Settings -> Audio -> Output Device -> The "Default" setting is untranslatable. ~~ Spotted by @xujibbs . SECTION REDESIGNED, FIXED
  • ~~Settings -> Memory Cards: The "Create" option at the right-click menu is untranslatable.~~
  • ~~Settings -> Memory Cards -> Create window: the top window box is limited to two lines of description and needs to be expandable.~~ SOLVED IN #10700 .
  • ~~Settings -> Memory Cards -> Convert: The 2x Memory Card description has slightly different texts in both copies of the string. These should be unified.~~
  • ~~Settings -> Network and HDD -> DNS1 & 2 Address -> The "Auto"/"Manual"/"Internal" strings are untranslatable. Spotted by @xujibbs .~~
  • ~~Settings -> Achievements -> Game Information box -> It's too small at this moment or lacks a slider bar.~~ BOX REDESIGNED, FIXED
  • ~~RetroAchievements login window: The window size is hardcoded, so whenever a longer string appears, the window seems to be jumping around (reported on Discord).~~

GAME PROPERTIES WINDOW

  • ~~Summary -> "Type:" setting name is untranslatable.~~
  • ~~Graphics -> Display: The Screenshot Size area is fudged/not fit for translation, and also, many options that have short boxes are broken (trying to display "Default: (value)").~~ CONSEQUENCE OF THE STRING "USE GLOBAL SETTINGS", IRRELEVANT
  • ~~Rendering -> Post-Processing: more of the same.~~ CONSEQUENCE OF THE STRING "USE GLOBAL SETTINGS", IRRELEVANT

CONTROLLERS WINDOW

  • ~~Controllers -> USB -> Wheel Devices -> Settings: all subsettings are untranslatable (the percentage signs and the Steering Damping settings).~~
    • ~~Can be found at pcsx2\USB\usb-pad\usb-pad.cpp:173, 177 and 180.~~
  • ~~Controllers -> USB -> ALL SETTINGS -> Please double-check that all the units and percentage signs are translatable. These are needed so languages that require adding a space between number and signs can do so, and it is already done in other parts of the UI.~~
  • ~~Controls -> Hotkeys -> The "&" that appears whenever a Hotkey has multiple entries should be translatable. imagen~~ Won't fix
  • ~~Controls -> Clear Bindings question: "Are you sure you want to clear all bindings for this controller?" should read "for this USB device?" when selecting an USB device.~~
  • ~~Controllers -> USB -> Microphones (Singstar, Logitech, etc): "Not Connected" and "Default Input Device" are not translatable.~~

INPUT RECORDING

  • ~~Input Recording Viewer: column names are untranslatable.~~

ACHIEVEMENTS

  • ~~The contents inside the variables of the string "{0} cannot be performed while hardcore mode is active. Do you want to disable hardcore mode? {0} will be cancelled if you select No." seem to be untranslatable at this moment.~~

OTHER STRINGS

  • ~~The substrings for "Saving {0} GS dump {1} to '{2}'" are untranslatable at this moment.~~

BIG PICTURE/ON-SCREEN MESSAGES/IMGUI

  • ~~A number of strings were left untranslatable after the latest Big Picture push. These are mostly subheader names within the Settings menu, like On-Screen Display, Operations, BIOS Configuration, Options and Patches, Console Port 1, Console Port 2, all the setting names and descriptions for "Controller Port X Settings", Not Connected, Account, Current Game, Logging.~~
  • ~~Settings -> Controller Settings -> Macro X Buttons -> Frequency -> the sublabel's many options are untranslatable.~~
  • ~~Game List -> Game List Settings -> Download Covers option is not working.~~
  • ~~Game Properties -> Cheats -> Gray warning texts might require multiple lines or ticker animation support so longer translated lines can be properly displayed.~~

Reproduction Steps

Go to each menu in a non-English language using stenzek's PR artifacts: https://github.com/PCSX2/pcsx2/pull/9054

Expected Behavior

Cleaner translated UI.

IlDucci avatar Jun 24 '23 17:06 IlDucci

Controls -> Hotkeys -> The "&" that appears whenever a Hotkey has multiple entries should be translatable.

This one's a WONTFIX. The & is a control character in how the binding is parsed, and the binding itself is not translatable.

stenzek avatar Jun 25 '23 02:06 stenzek

List updated, focusing on the Settings window. I'm leaving things at the Emulation section (included) for now.

IlDucci avatar Jun 27 '23 10:06 IlDucci

Updated the list with the comments mentioned in https://github.com/PCSX2/pcsx2/issues/9122 . It seems that we have some regressions.

IlDucci avatar Jun 30 '23 09:06 IlDucci

Settings -> Emulation -> System Settings: Decouple the "Disabled" string. So far I only see two copies (EE Cycle Skipping and Affinity Control), but there seems to be four? Settings -> Graphics -> Maybe decouple all the "None"/Auto" strings so genders/numbers can be customizable depending on the option?

This one's a nope. The noop macro doesn't have disambiguation.

Settings ->Interface -> Maybe change the "Language:" string so all non-English languages display instead "Language [in the destination language] (Language) [in English]:"?

Also a won't fix - that would massive increase the number of items in the language list, as not all languages follow the same sentence form.

stenzek avatar Jun 30 '23 11:06 stenzek

Settings ->Interface -> Maybe change the "Language:" string so all non-English languages display instead "Language [in the destination language] (Language) [in English]:"?

Also a won't fix - that would massive increase the number of items in the language list, as not all languages follow the same sentence form.

Just to be sure I did not misexplain, this is the intended effect: "Idioma (Language):". Just the setting name, not the available languages. It could pretty much be done by just changing the string and adding a comment for translators to do this instead.

IlDucci avatar Jun 30 '23 14:06 IlDucci

Settings -> Emulation -> System Settings: Decouple the "Disabled" string. So far I only see two copies (EE Cycle Skipping and Affinity Control), but there seems to be four? Settings -> Graphics -> Maybe decouple all the "None"/Auto" strings so genders/numbers can be customizable depending on the option?

This one's a nope. The noop macro doesn't have disambiguation.

In that case, any elements that can not be disambiguated should have a comment for translators so they know they have to find a way or a workaround to avoid any gender/number issues that arise from that (an example I do in Spanish is adding a noun that supersedes the gender, for example, instead of just using "Default", I use "Default value".)

IlDucci avatar Jun 30 '23 14:06 IlDucci

Revision updated: I have finished going through the Settings and Controller windows. Still have to check all the other windows.

IlDucci avatar Jul 01 '23 09:07 IlDucci

Just to be sure I did not misexplain, this is the intended effect: "Idioma (Language):". Just the setting name, not the available languages.

Not really sure what you mean by this. The setting name is part of the .ui file, and should already be translatable.

You can add additional context/information on crowdin.

stenzek avatar Jul 01 '23 13:07 stenzek

In Rendering -> Post-Processing, the Constant Adaptive Sharpening doesn't seem to show up anywhere, where the string have been modified in any way. It's on the screenshot in the OP but isn't really pointed out.

Edit: In the same tab of options, "Saturation" for both tooltip title and the option itself seems to be one single string.

nikivarvar avatar Jul 14 '23 23:07 nikivarvar

The "Scan Recursively" column on the Game List setting needs to be made wider to accomodate with translation strings in cases where they are longer than the source string

image

EDIT: Just noticed that it's already known.

kamfretoz avatar Jul 15 '23 13:07 kamfretoz

Game List view: "hours", "minutes" and the "never" words that are used to track playtime and if the game has been played yet, cannot be translated. Searched strings on Crowdin and confirmed we cannot translate it yet, there are not such strings.

bigol83 avatar Aug 02 '23 12:08 bigol83

Fairly sure "quadrafonic" is supposed to be "quadraphonic".

HarmfulBreeze avatar Aug 29 '23 12:08 HarmfulBreeze

Little update: now the game list playtime words such as "seconds", "hours", "minutes", "never", "today", "yesterday" can be translated on Crowdin.

But it seems date format is still based on US, there is no option to change it into another format. This can be confusing for European users. Dates such as 08/05/2023 mean May 8th in Europe, while they mean August 5th in US format.

bigol83 avatar Sep 06 '23 10:09 bigol83

It should use whatever the locale of your system is, for date formatting.

stenzek avatar Sep 06 '23 10:09 stenzek

Checked my local date formatting and it uses the EU one as it should yet Pcsx2 uses the US one.

bigol83 avatar Sep 06 '23 10:09 bigol83

I can confirm the locale settings are not being used by PCSX2 in a Windows PC with Spanish (Spain) settings. The date sorting is the US one and the size of the images uses a decimal period, not a comma.

(Texts are in English because the strings have not been updated yet) imagen

IlDucci avatar Sep 07 '23 12:09 IlDucci

Translations meta thread updated with all the reports, plus a bunch of untranslated strings that I just found in Big Picture. These strings might not be the only ones, so if any of the reporters reads this, please do some research work as well.

IlDucci avatar Sep 16 '23 10:09 IlDucci

There is a small typo in the following string below. "Calculate", not "Calclate". 1694878891913

Hazer-123 avatar Sep 16 '23 15:09 Hazer-123

The Interlace dropdown says None (Interlaced, also used by Progressive) which is incorrect, it should probably just say None (No Interlacing) I don't think it needs the progressive addition here either.

refractionpcsx2 avatar Sep 19 '23 14:09 refractionpcsx2

The Interlace dropdown says None (Interlaced, also used by Progressive) which is incorrect, it should probably just say None (No Interlacing) I don't think it needs the progressive addition here either.

Sure, but quite a few users will also think no interlacing = progressive

RedDevilus avatar Sep 19 '23 14:09 RedDevilus

It is?

refractionpcsx2 avatar Sep 19 '23 14:09 refractionpcsx2

It is?

What about if the game doesn't give/have progressive signals? I thought that would just be Interlaced unless I understood it wrong.

RedDevilus avatar Sep 19 '23 14:09 RedDevilus

if the game doesn't have progressive signals it'll look shaky. I'm saying "No Interlacing" so it doesn't do the interlacing, so if it looks broken, that's your own fault, what do they want from us? :P

refractionpcsx2 avatar Sep 19 '23 14:09 refractionpcsx2

I guess maybe it should be No Deinterlacing since that's the process. Is that clearer for you?

refractionpcsx2 avatar Sep 19 '23 14:09 refractionpcsx2

I guess maybe it should be No Deinterlacing since that's the process. Is that clearer for you?

I suppose that's fine.

RedDevilus avatar Sep 19 '23 15:09 RedDevilus

I believe "Expansion" should be "Upmixing". "Upmixing" is a much more common audio term.

Google searches: https://www.google.com/search?q=audio+expansion https://www.google.com/search?q=audio+upmixing

HarmfulBreeze avatar Sep 20 '23 13:09 HarmfulBreeze

I believe "Expansion" should be "Upmixing". "Upmixing" is a much more common audio term.

Google searches: https://www.google.com/search?q=audio+expansion https://www.google.com/search?q=audio+upmixing

If I remember correctly Expansion was used because it's virtual emulation of surround sound so faking it more-so but a fair remark.

Not sure what to do with it so I'll leave it to someone else at the moment.

Though it also has stereo for option as listed below:

image

RedDevilus avatar Sep 20 '23 13:09 RedDevilus

List updated with a full, comprehensive sublist for Big Picture. I am also going to attempt to make a few strings translatable.

IlDucci avatar Sep 30 '23 10:09 IlDucci

This string should be "CPU Sprite Render Size", or other similar strings should be adjusted accordingly https://crowdin.com/proofread/pcsx2-emulator/15/en-fr#5143 https://github.com/PCSX2/pcsx2/blob/ec53e8949a4affafb5315efd5af8f52c9d3a034f/pcsx2-qt/Settings/GraphicsSettingsWidget.cpp#L512

HarmfulBreeze avatar Oct 07 '23 15:10 HarmfulBreeze

This string should be "CPU Sprite Render Size", or other similar strings should be adjusted accordingly https://crowdin.com/proofread/pcsx2-emulator/15/en-fr#5143

https://github.com/PCSX2/pcsx2/blob/ec53e8949a4affafb5315efd5af8f52c9d3a034f/pcsx2-qt/Settings/GraphicsSettingsWidget.cpp#L512

Fixed in https://github.com/PCSX2/pcsx2/pull/10363 .

IlDucci avatar Dec 12 '23 10:12 IlDucci