pcsx2 icon indicating copy to clipboard operation
pcsx2 copied to clipboard

[BUG]: Onimusha 3, ako/samanosuke teleport vfx and pink barrier mist vfx messed up

Open washingleavesandthensome23-434 opened this issue 1 year ago • 19 comments

Describe the Bug

Akos/Samanosukes teleport vfx is messed up also pink barrier mist vfx are messed

Reproduction Steps

Play Paris level from start

Expected Behavior

Not having said vfx issues

PCSX2 Revision

1.7.4583

Operating System

Windows 11

If Linux - Specify Distro

No response

CPU

I9-13900K

GPU

4090

GS Settings

No response

Emulation Settings

No response

GS Window Screenshots

150457cb-0cfc-4dd2-91b6-3d9a60d60b50

0b4fefe5-8cfc-41a8-87aa-6313d7c12a1a

d28823b4-91d1-4252-bbf7-efcc1704d700

Logs & Dumps

No response

can i have a gs dump

Mrlinkwii avatar Jun 15 '23 22:06 Mrlinkwii

A sec

That GS dump looks pretty much identical in HW and SW, and also doesn't match the screenshot above.

stenzek avatar Jun 16 '23 09:06 stenzek

K, lemme get a better gsdump

K and fresh dumps also updated screen shots

Download.zip

this gs dump is the same in HW/SW ( as i can see to say , dont upscale) image

while this gs dump dose have an issue in HW
image

Mrlinkwii avatar Jun 18 '23 16:06 Mrlinkwii

Bout the pink barrier mist perhaps I wasn't clear enough, a sec

the issue is clearly present in software also, so a more fundamental issue perhaps:

image_6-18-23_21-38-15

Your own screen shot btw🙂

it shows the issue is clearly present on the pink barrier mist as well i just tested with vulkan in native res issue is present

Screenshot_20230618_215147_Discord

image_6-18-23_21-39-47

it's not supposed to be a grid pattern, it's supposed to be rising smoke Here it is more clearly

image_6-18-23_21-40-27

Onimusha_3_-_Demon_Siege_SLUS-20694_20230618204056

Software mode btw; image_6-18-23_21-48-18 needs to be smooth with no breaks showing.

And gsdump

Onimusha_3_-_Demon_Siege_SLUS-20694_20230618204056.zip

This is how it's supposed too look btw

Screenshot_20230618_215533_Kiwi Browser

https://m.youtube.com/watch?v=ehNk_uZQ4fg&pp=ygUPT25pbXVzaGEzIHBhcmlz

@10:38, look at pink smoke wall on ps2

@washingleavesandthensome23-434 can you reupload that gs dump again , it seemed to fail uploading

Mrlinkwii avatar Jun 18 '23 19:06 Mrlinkwii

Updated

Also how teleport

Is supposed too look, from ps2

Screenshot_20230618_224638_Kiwi Browser

And here's how akos teleport should look including particles

Screenshot_20230618_231022_Kiwi Browser

Screenshot_20230618_230915_Kiwi Browser

Screenshot_20230618_230923_Kiwi Browser

All can be seen in original ps2 trailers

https://m.youtube.com/watch?v=IPy1uqKRepg

https://m.youtube.com/watch?v=9xq8-1l9tVA

Seeing these bugs on my end as well. I'm not entirely sure in which update they appeared, but I can confirm that as of 22nd of October 2022 at the earliest, these vfx bugs were not present.

DrunkRichtofen avatar Jun 20 '23 13:06 DrunkRichtofen

@devs, Hope ya got everything needed too fix these bugs, if ya need anything else lemme know 🙂

A bisect to the exact build which broke it would be helpful.

My usual go-to is to compare hardware to software to pinpoint what the issue is, but if software's broken, but was previously fine, we'll need to know when that changed.

stenzek avatar Jun 23 '23 09:06 stenzek

I'm currently running through earlier builds to narrow down which build introduced this bug. So far, I've found that both vfx bugs were not present in build 1.7.4308, so this occured within the last 2-3 months at most. I'll run through more builds and try to narrow it down.

DrunkRichtofen avatar Jun 24 '23 19:06 DrunkRichtofen

Appreciated man this helps out alot🙂

I've managed to find the exact builds that these regressions were introduced in. The red fog bug appeared in v1.7.4428, while the Time Fold and Ako teleport bugs both appeared in v1.7.4438

DrunkRichtofen avatar Jun 24 '23 21:06 DrunkRichtofen

Holy f! Very nice work my dude!🫡

Btw for those interested in what the overlay on the barrier is, The weird square gradient that showed in recent builds, is actually from the item preview textures They are the only textures in the entire game that has that watermark, Top left corner, this is exactly the icon that appears on the barrier Each item preview has their own colored version of the icon, It does have its own texture It used to have the left half be an alternate version of the right half, however it now dumps it as a corrupt texture image (1)

Corrupt texture

image (2)

Can you try ingame with https://github.com/PCSX2/pcsx2/pull/9076 ?

Since the texture data has already been corrupted when you made those GS dumps, it's still busted when playing them back, but hopefully it'll be correct if you fresh boot the game (don't use a save state).

stenzek avatar Jun 25 '23 11:06 stenzek

Well in order too test I'll need an updated build right? I'll have too wait on merge into master 🤔

You can get a build from the checks at the bottom of the pr , just press details next to one of the windows builds with a tick, then go to summary

refractionpcsx2 avatar Jun 26 '23 00:06 refractionpcsx2

Ngl I'm confused asf , im just moving in circles cant find download 😥

sigh

Fine, just get this https://github.com/PCSX2/pcsx2/suites/13845279791/artifacts/768979923

refractionpcsx2 avatar Jun 26 '23 00:06 refractionpcsx2

Lol, appreciated 🫡, gimme a few hours too test

image_6-26-23_17-17-23

So texture dumping works again using that testbuild😎

not really concerned about the texture dumping, does the game look right?

refractionpcsx2 avatar Jun 26 '23 15:06 refractionpcsx2

Yup all 3 issues fixed🫡😎

Ya done good @devs, appreciated very much for fixing 🫡