pcsx2
pcsx2 copied to clipboard
PINE: Update to the age of Qt
Description of Changes
Since the death of wx, PCSX2 has been without PINE. I've now done my best to make it work again.
I've replaced the old threading with std::thread, and done some changes to prevent heap corruption.
There are also some minor changes made like moving the allocation of the static buffers to the constructor instead of leaving that to the worker thread.
And of course the GUI:
There is one minor thing I couldn't figure out a good way of doing though. PINE is supposed to start on emulator startup, but the only ways I found to achieve this had one of two issues:
- The config hadn't loaded yet
- It reloaded PINE on every config change, causing lots of servers spawning when editing the slot one digit at a time
Rationale behind Changes
PINE good.
Suggested Testing Steps
Test the GUI and test PINE I suppose. I've tested PINE on windows, but not on linux, so if anyone can test it on linux that'd be great.
@stenzek can you give it another quick look over please, cheers :)
is allowing on/off but not allowing port change the intended behavior for the per game settings?
@stenzek Can you check this again?