[BUG]: Half pixel offset only works in certain levels

[mirh]

Describe the Bug

Half pixel offset seems to do anything at all only in some levels. Where it works, the "viewport" is indeed offsetted a bit, and it leads to a sensible increase in textures detail too. Elsewhere, nothing.

Reproduction Steps

Apply 4x resolution. In Ace combat 5: compare level 13 "Demons of Razgriz" to level 3 "Narrow Margin" (or menus). Try to toggle Half Pixel Offset.

Expected Behavior

Now, I don't really have a benchmark to tell whether this leads to washed out textures in the missions where it doesn't apply (and this is eventually the only thing that you'd want to care) But the menus not moving at all seems to give pretty safely away the fact that something's broken somewhere.

PCSX2 Revision

v1.7.3073

Operating System

Windows 10 (64bit)

CPU

i5-10300H

GPU

RTX 3060 laptop

Logs & Dumps

snaps.zip (if you compare the provided screenshots, you can notice how the UI is ever so slightly shifted in the "works" case)

[lightningterror]

That's how it's supposed to work, it doesn't cover all types of draws, it's a hack, and where it doesn't work you use other type of upscaling hacks.