pcsx2 icon indicating copy to clipboard operation
pcsx2 copied to clipboard

[BUG]: Star Ocean can't collect battle trophies with memcard folder format

Open BParks21 opened this issue 2 years ago • 5 comments

Describe the Bug

Trophies cannot be collected properly. When creating a new trophy file as well as a new save file you are able to collect trophies immediately after doing so. However as soon as you quit the game and relaunch it and earn some new trophies it always reports the trophy data as corrupt. This shouldn't happen with newly created trophy data. Works as intended with the old shared format.

Reproduction Steps

Set memcard to folder, start a new game of star ocean and create new battle trophy data. Earn some trophies before exiting the game. You should be able to save these trophies in the first session when the trophy data is created. Close the game, relaunch it and earn some more trophies. You will not be able to save them this time and will receive the corrupt message.

Expected Behavior

Should be able to continue collecting trophies using the folder format. Should behave as the shared format.

PCSX2 Revision

v.1.7.3066

Operating System

Windows 10 (64bit)

If Linux - Specify Distro

No response

CPU

i7 8086k

GPU

Nvidia GTX 1080ti

GS Settings

Default

Emulation Settings

Default

GS Window Screenshots

No response

Logs & Dumps

No response

BParks21 avatar Jul 10 '22 19:07 BParks21

Anyone get a chance to look into this yet?

BParks21 avatar Aug 04 '22 18:08 BParks21

I have some loose, baseless theories but nothing actionable. As a wild shot in the dark, you could try a build of this PR to see if it miraculously starts working. This PR fixes an unusual behavior where games out of the blue change their read/write size from 128 to 250, and I've seen it fix Shining Force EXA and MGS3 already, so perhaps this game is having this same issue now?

RedPanda4552 avatar Aug 04 '22 19:08 RedPanda4552

I have some loose, baseless theories but nothing actionable. As a wild shot in the dark, you could try a build of this PR to see if it miraculously starts working. This PR fixes an unusual behavior where games out of the blue change their read/write size from 128 to 250, and I've seen it fix Shining Force EXA and MGS3 already, so perhaps this game is having this same issue now?

Just tested it. Doesn't seem to fix it.

BParks21 avatar Aug 04 '22 19:08 BParks21

Can confirm this is still an issue in 1.7.3307, was an unpleasant surprise on my SteamDeck. Tried with both SteamDeck and my main PC using 1.7.3307. Taking the exact same folder save that is "corrupt" to a 1.6.0 install on my PC allows saves to happen without corruption message (ie no reinit, no changes made externally other than copying folder from 1.7.3307 install to 1.6.0 install). Trying to convert the folder into an 8MB file continues the corruption messages unfortunately, but isn't unexpected given how BT data is so sensitive.

Given that 1.6 can successfully use the folder even when 1.7 can't, it has to be something with 1.7's method of accessing I would assume.

armouredking avatar Sep 15 '22 20:09 armouredking

Look forward to a solution to this!

BParks21 avatar Sep 16 '22 17:09 BParks21

I'm running into this problem now as well. Forgive my ignorance as I'm not familiar with this code base.

I have an old memory card file from 2012 (.ps2 format), and I've been playing with a save file on that memory card. When I get a new trophy I get this message. I don't necessarily expect such an old file to be compatible with the current version of pcsx2, so I'm not complaining about that part. Just signaling that if there are "old" and "new" memory card structures, it might be a problem on both.

ckx avatar Dec 10 '22 00:12 ckx

No fix for this yet dang.

BParks21 avatar Jan 21 '23 02:01 BParks21

From discord, this is still an issue.

DigitalMajestic avatar Aug 26 '23 00:08 DigitalMajestic

This seems fixed. I deleted my battle trophy data, created a fresh battle trophy save file using the folder format and I'm able to save all battle trophies earned.

BParks21 avatar Feb 13 '24 00:02 BParks21

Thanks for the update!

refractionpcsx2 avatar Feb 13 '24 00:02 refractionpcsx2