pcsx2 icon indicating copy to clipboard operation
pcsx2 copied to clipboard

Various patch fixes ( addresses #6220 and #6219 )

Open Tupelov opened this issue 3 years ago • 8 comments

Description of Changes

Fixed the issue where pnachs wouldnt load from the cheats subfolder and added the ability to prefix hex in pnachs with 0x Fixes #6219

Fixes #6220

Rationale behind Changes

Convenience and bugfixing

Suggested Testing Steps

Litterally just make a pnach

Tupelov avatar May 27 '22 17:05 Tupelov

Can you write the following lines in the OP please, that will auto close them when the PR merges.

Fixes #6219

Fixes #6220

refractionpcsx2 avatar May 27 '22 17:05 refractionpcsx2

Done

Tupelov avatar May 27 '22 18:05 Tupelov

Seems to work for the most part, unless I mistype the addresss/value and put 0x twice like 0x0x12345678, that seems to make the patch not work, at least. It's fine if you don't wanna handle that, that was just me pissing around trying to break it :P

refractionpcsx2 avatar May 27 '22 18:05 refractionpcsx2

Can you action the above please, then we can get this merged. Thanks.

refractionpcsx2 avatar Jun 04 '22 01:06 refractionpcsx2

Any update on this?

lightningterror avatar Jun 14 '22 19:06 lightningterror

Sorry, I've been on a trip and I missed the message before I left, I plan on getting the PR done sometime next week, again, sorry.

Tupelov avatar Jun 17 '22 20:06 Tupelov

Are you not going to action Stens other request then? you marked it as resolved but didn't actually do anything with it.

refractionpcsx2 avatar Jun 20 '22 06:06 refractionpcsx2

@Tupelov Status?

lightningterror avatar Sep 02 '22 04:09 lightningterror

Closing as it isn't being worked on.

lightningterror avatar Oct 17 '22 16:10 lightningterror