pcsx2 icon indicating copy to clipboard operation
pcsx2 copied to clipboard

[Feature Request]: (Qt) A couple of suggestions

Open Rex000 opened this issue 2 years ago • 13 comments

Description

  1. An option to remove personalized game settings in the right-click menu of a game.

  2. A "Save" button alongside the "Close" button in both global and per-game settings.

Reason

  1. Being able to remove personalized settings with one click will help the user to immediately reset all their changes instead of manually deleting the game settings file each time.

  2. Currently the "Close" button and even the "X" button on top-right not only closes the Settings window but also saves the changes which may not always be desirable by the user.

Examples


Rex000 avatar May 24 '22 23:05 Rex000

  1. Is there not a defaults button? I forget.
  2. No need, it saves each option as it changes

refractionpcsx2 avatar May 24 '22 23:05 refractionpcsx2

  1. Is there not a defaults button? I forget.
  2. No need, it saves each option as it changes
  1. I don't think there is one. I couldn't find it in the right click menu of games. There is only "Default Boot".

  2. Imo settings should not automatically save without user consent. This also prevents a lot of confusion especially if the user made changes on different occasions. I've seen this in other emulators where settings are only saved if the "Save" button is clicked, which is the most appropriate way because the Close button is only supposed to nullify all the changes (if Save is not clicked) and close the window.

Rex000 avatar May 25 '22 00:05 Rex000

All the settings widgets are designed to apply immediately and not buffer changes. It makes testing much easier, since you can quickly change settings and observe the differences

Imo settings should not automatically save without user consent.

This isn't really the case in modern applications. Look at anything with recent UI redesigns, and you won't find save/apply buttons either.

stenzek avatar May 25 '22 07:05 stenzek

All the settings widgets are designed to apply immediately and not buffer changes. It makes testing much easier, since you can quickly change settings and observe the differences

Imo settings should not automatically save without user consent.

This isn't really the case in modern applications. Look at anything with recent UI redesigns, and you won't find save/apply buttons either.

It may make testing easier but as I stated, it makes it confusing for the regular user because it occurs more than often they can't keep track of the changes.

I'm looking at modern emulators like RPCS3 which provides buttons like "Save" and even "Apply". This approach might be old school but is more user-friendly.

However, I can see where you're coming from. You guys know it best. I hope we at least get the option to remove/reset all changes in the right-click menu of any game.

Rex000 avatar May 25 '22 18:05 Rex000

All the settings widgets are designed to apply immediately and not buffer changes. It makes testing much easier, since you can quickly change settings and observe the differences

This could easily be worked around by having the close button reset to the configs last saved state, then you can have the live changes while also not making anything permanent without the user saying so

Seems like a no brainer really, Hell you could just add an autosave checkbox in the corner if some user want that...

xproflipscarab avatar Aug 04 '22 10:08 xproflipscarab

This could easily be worked around by having the close button reset to the configs last saved state, then you can have the live changes while also not making anything permanent without the user saying so

So how would you ever save anything?

refractionpcsx2 avatar Aug 04 '22 10:08 refractionpcsx2

I think the best would be to add a "Undo all current changes (this session)" button.

Rex000 avatar Aug 04 '22 18:08 Rex000

I don't see the point of undo current session changes. You aren't going to mess up settings that badly. And even if you do, A) set-default option (if there is one) can be used. B) set whatever you messed up to the default value. (Which are explicitly stated on multiple settings)

Daisouji avatar Aug 04 '22 21:08 Daisouji

we are missing a reset to defaults button atm, but that's coming at some point, I think that's the more sensible option than these complicated options that change depending on if you're holding your hand in the air and if you had fries for dinner and your mothers name is Janet.

refractionpcsx2 avatar Aug 04 '22 21:08 refractionpcsx2

One may already have some settings that they changed earlier at some point and likely would want to keep those. A "Reset to defaults" button is ok, but then it will also reset all of those previous changes. Then what will happen is that the user will need to make all those changes again, provided they hopefully remember all of them. That's the reason why I suggested a "Undo all current changes (this session)" button instead. The idea here is not to revert everything to default but to revert to previous settings. Maybe have both buttons?

Rex000 avatar Aug 04 '22 22:08 Rex000

I don't think there's any need for anything beyond reset to defaults. Most fixed are automatic (at least we'd like them to be automatic), so any game specific changes you make should be minor, so resetting isn't a big deal.

Moreover, doing game specific settings should be a "do once, never touch again" affair, but again as above, as long as it's not Skipdraw or texture offsets, but the game needs game fixes/hw fixes, we would prefer to have them in the game DB so they are automatic for everybody.

refractionpcsx2 avatar Aug 04 '22 22:08 refractionpcsx2

This could easily be worked around by having the close button reset to the configs last saved state, then you can have the live changes while also not making anything permanent without the user saying so

So how would you ever save anything?

By using a save button while having the close button reminding the user that their changes have not been saved like any other user friendly design ever... Don't see how this isn't a no brainer, it gives users more options while also adding no complexity whatsoever...

Who is going to complain about a window confirming whether you want to save your changes or not...

xproflipscarab avatar Aug 05 '22 16:08 xproflipscarab

This isn't really the case in modern applications. Look at anything with recent UI redesigns, and you won't find save/apply buttons either.

Also, the system doesn't have any support for reverting changes, nor do I have any interest in rewriting it to do so. You're welcome to implement it yourself of course.

stenzek avatar Aug 05 '22 17:08 stenzek

Reset to defaults button has been implemented.

lightningterror avatar Oct 18 '22 20:10 lightningterror