pcsx2 icon indicating copy to clipboard operation
pcsx2 copied to clipboard

Published 20 hours ago • verified publisher icon PCSX2

[Draft] Qt Debugger

Open F0bes opened this issue 2 years ago • 2 comments

PRing as draft, maybe it'll motivate me a bit more.

Current issues:

  • Memory View is empty when the VM hasn't run yet
  • The Register View and Disassembly view can be refactored
  • Actually everything can be refactored for consistency
  • Themeing is really broken
  • VM state management in the debugger is ugly and a hack
  • No key shortcuts
  • No Memory search
  • ~~I don't think R3000 stuff really works~~
  • Step out doesn't work (Haven't implemented mips stack walk stuff)
  • ~~Memory view rows aren't dynamic~~
  • No function list
  • ~~Entering text in the memory view doesn't move to the next byte~~
  • ~~Data breakpoints aren't implemented~~
  • ~~Breakpoint list is missing~~
  • Updating isn't consistent across each view
  • Branch lines should be fixed

😮‍💨

F0bes avatar May 24 '22 01:05 F0bes

C'mon CI, do your worst.

F0bes avatar May 24 '22 01:05 F0bes

On behalf of the fan translation community i would like to say Thank You for working on this!

Risae avatar May 24 '22 05:05 Risae

I just need keybinds, otherwise I'm pretty much finished the initial stuff. Next pr would be to improve how it interacts with the core.

I'll squash when it's reviewed and stuff.

F0bes avatar Dec 09 '22 01:12 F0bes

Please how is configured for Valkyrie Silemria 2 the part of the forest that looks checkered

Eleazar8612 avatar Dec 09 '22 12:12 Eleazar8612

Please how is configured for Valkyrie Silemria 2 the part of the forest that looks checkered

I think you've gotten lost. Please join our discord for support.

F0bes avatar Dec 09 '22 16:12 F0bes

The memory search works great, but the debugger lacks the option to create an arbitrary memory dump (eg. to dump EE ram for use as an overlay with something like PS2Dis to enable static/offline analysis).

I realize that save states could be used for this purpose, but it would be nice to have a dedicated option for creating a single named-dump file (which would include the memory used by a game, without all the other stuff).

neoh4x0r avatar Dec 11 '22 22:12 neoh4x0r

Good idea. When possible, I can add this to the memory view dialog :)

F0bes avatar Dec 11 '22 22:12 F0bes

Ready for review. There will be conflicts with #7610, Unsure if this is going to be merged before or after this, it's not a big deal, mostly some debuginterface stuff from what I can gather. I'm thinking of squashing into two commits? One for the initial core work, and the actual debugger into another. It's going to be a pretty big commit, but this is pretty big work.

F0bes avatar Dec 21 '22 19:12 F0bes

That's it. 🥲

F0bes avatar Dec 24 '22 06:12 F0bes