pcsx2 icon indicating copy to clipboard operation
pcsx2 copied to clipboard

[BUG]: Die Hard: Vendetta- Arm twitching on both renderers, texture/mipmapping issues on HW renderer

Open HeroponRikiBestest opened this issue 3 years ago • 11 comments

Describe the Bug

Both renderer issues-

HW Renderer issues-

  • The ground texture, shadows, and other textures, such as the statue texture in the opening mission, appear too sharp on the HW renderer. Setting mipmapping to Basic or Full partially fixes this, but only somewhat; the textures still remain too sharp in comparison to the SW renderer, which handles them correctly. HW renderer- gs_20211209061548 gs_20211209061548.gs.zip SW renderer (Correct)- gs_20211209061611 gs_20211209061611.gs.zip
  • Leaves on some trees flicker on HW renderer. May be the same issue as the previous one, but I'm not certain. gs_20211209062001.gs.zip

Additional notes: There seem to be some artifacts visible on the HW renderer just after the load screen ends on multiplayer, possible on singleplayer as well. I am unable to provide GSdumps, as at the moment I cannot produce a single GSdump from ctrl + shift + f8, and the timing would be too precise for me to capture it with just shift + f8. If I can resolve that issue, I will update this post with the aforementioned GSdump.

These issues were observed on both the European and German versions of the game. The only difference noticed between these versions is that swapping the renderer during a load screen makes the background disappear on the German version, while swapping renderers does nothing on the European version, and the background will only disappear on a load screen if you load a save state during it. Obviously, neither of these things are issues.

To anyone testing the game in the future: yes, the gate on the first mission is supposed to look like that, even on a real PS2. It only looks correct on the xbox version, which was probably the main target for this port.

Reproduction Steps

All issues will be normally experienced by starting a new game and playing from there. In order to see the twitching on your arm, press circle to outstretch your gun during gameplay.

Expected Behavior

Expected behavior was laid out in the bug descriptions.

PCSX2 Revision

PCSX2 1.7.0-0 - compiled on Dec 9 2021 (daily ppa doesnt show git number)

Operating System

Linux (64bit) - Specify Distro Below

If Linux - Specify Distro

Linux Mint 20.2

CPU

AMD Ryzen 7 PRO 4750U with Radeon Graphics

GPU

Integrated graphics, see above

GS Settings

No response

Emulation Settings

No response

GS Window Screenshots

No response

Logs & Dumps

No response

HeroponRikiBestest avatar Dec 09 '21 12:12 HeroponRikiBestest

Can you make a gsdump using dev 1961 or earlier so we can test old gs versions and rule out that it's a regression (for twitching bug)?

prafullpcsx2 avatar Dec 12 '21 14:12 prafullpcsx2

Tested arbitrarily using https://github.com/PCSX2/pcsx2/actions/runs/1396343026. All issues appear to be present. gs_20211212092037.gs.zip

HeroponRikiBestest avatar Dec 12 '21 14:12 HeroponRikiBestest

https://buildbot.orphis.net/pcsx2/index.php?m=dl&rev=v1.7.0-dev-1961-g4273b6ce37&platform=windows-x86

prafullpcsx2 avatar Dec 12 '21 14:12 prafullpcsx2

I use Linux; furthermore, that PR I linked was made a few days before dev 1961, so it should be valid here.

HeroponRikiBestest avatar Dec 12 '21 14:12 HeroponRikiBestest

It still gives savestate too old to be read message when trying to open the gsdump. Anyway I will check the game myself and see what can be done.

prafullpcsx2 avatar Dec 12 '21 15:12 prafullpcsx2

@prafullpcsx2 I was able to get 1961, sorry about that. Here's a gsdump; all issues still seem to be visible gs_20211212105738.gs.zip

HeroponRikiBestest avatar Dec 12 '21 15:12 HeroponRikiBestest

@HeroponRikiBestest Thanks. Looks like twitching has always been there on pcsx2 so it's not a regression.

prafullpcsx2 avatar Dec 12 '21 16:12 prafullpcsx2

Yeah; again, sorry about getting the wrong dev build, I know what to do in the future now at least. Any idea about the HW mipmapping issues?

HeroponRikiBestest avatar Dec 12 '21 16:12 HeroponRikiBestest

Does either of the Trilinear Filtering modes improve the appearance of the textures? (Config → Graphics Settings → Hacks → Trilinear Filtering)

Dreadmoth avatar Dec 13 '21 01:12 Dreadmoth

It helps, but it has a similar effect to mipmapping basic/full, where it only partially fixes them.

HeroponRikiBestest avatar Dec 13 '21 09:12 HeroponRikiBestest

I don't know if I just didn't notice it before or it was introduced recently, but now SW mode gets some red and/or blue garbage in the bottom left. It's a little hard to notice in screenshots, but its pretty noticeable in motion. gs_20211231030742 gs_20211231030742.gs.zip

HeroponRikiBestest avatar Dec 31 '21 11:12 HeroponRikiBestest

Mipmapping issues should be resolved now.

lightningterror avatar Dec 12 '22 04:12 lightningterror

which issues are left here ? since the Mipmapping issues were sloved

Mrlinkwii avatar Aug 07 '23 19:08 Mrlinkwii

We did some testing and it seems to be affected by rounding on VU0 and FPU

refractionpcsx2 avatar Aug 14 '23 20:08 refractionpcsx2