pcsx2 icon indicating copy to clipboard operation
pcsx2 copied to clipboard

[BUG - BIOS] Audio CDs doesn't work anymore.

Open ghost opened this issue 4 years ago • 11 comments

Describe the bug Audio CDs won't play any music anymore in the BIOS.

Note: Now when playing a audio CD, the PCSX2 console spams: NCMD Unknown 7

To Reproduce Load the BIOS with a standard audio CD in the virtual tray.

Expected behavior The various tracks on the disc should play fine.

Emulation Settings Everything default.

Regression pull request: https://github.com/PCSX2/pcsx2/pull/1583

System Info PCSX2 Revision: pcsx2-v1.7.0-dev-pr[4171] OS: Windows 10 CPU: I9 9900k GPU: RTX 3070

ghost avatar Jan 24 '21 17:01 ghost

That regression pull request isn't correct.

Note: Now when playing a audio CD, the PCSX2 console spams: NCMD Unknown 7

#3899 is responsible for that, re-adding the large section of deleted code makes it play though the playback is pretty bugged - it repeats itself a lot and the time increments slowly. So there is another regression somewhere.

turtleli avatar Jun 07 '21 00:06 turtleli

The faulty playback was caused by #3877.

turtleli avatar Jun 07 '21 00:06 turtleli

I don't think this is really of much priority tho, given that you can use your PC to play those Audio CDs, and not bother with PCSX2 at all.

maxdlpee avatar Jun 07 '21 03:06 maxdlpee

The faulty playback was caused by #3877.

wait, what? how?

The PR that completely removed the CD Audio read calls seems a lot more freaking likely to me than the change of the read speeds.

refractionpcsx2 avatar Jun 07 '21 07:06 refractionpcsx2

I think there's a misunderstanding. #3899 made audio unplayable, whereas #3877 made audio sound buggy because the CD read speed is too slow.

turtleli avatar Jun 07 '21 08:06 turtleli

I see, I'm not sure how it's too slow, unless it's not CAV when it's doing CD Audio reads, which makes sense I suppose.

refractionpcsx2 avatar Jun 07 '21 08:06 refractionpcsx2

Here's some amusing playback with the deleted code put back in. "10s"

https://user-images.githubusercontent.com/10976277/120988512-8bc5da80-c776-11eb-8211-0fd99ad1de08.mp4

10s with CD speed change reverted (it's not perfect, but yeah)

https://user-images.githubusercontent.com/10976277/120988682-b2841100-c776-11eb-894d-e2cca9a648ff.mp4

turtleli avatar Jun 07 '21 09:06 turtleli

If this is a cd read speed issue couldn't this bug help dial into the ps2s exact read speed and maybe help fix other games with cdvd issues?

seta-san avatar Jun 18 '21 23:06 seta-san

I suspect audio cd's velocity changes so the speed matches wherever on the cd you are, it's only PS2 games where it uses CAV.

refractionpcsx2 avatar Jun 18 '21 23:06 refractionpcsx2

Thanks to the various CDVD timing changes, this is not an issue anymore, the only remaining gremlin is this log: image

ghost avatar Nov 14 '21 18:11 ghost

Apparently 0x2009 is the mode for the "where" registers 0x200c-0x200e (sec/min/hrs?)

0 = audio cd 1 = cd/dvd or something 2 = dvd

The reason it doesn't matter that we don't emulate it currently is because we're basically in permanent audio cd mode.

refractionpcsx2 avatar Nov 17 '21 11:11 refractionpcsx2

The problem stems from #7742

StillPlay2 avatar Oct 25 '24 18:10 StillPlay2