pcsx2
pcsx2 copied to clipboard
PCSX2
MacOS: Add pnach definition to Info.plist
Description of Changes
Ensures macOS treats it as a known file type, so it doesn't try to prevent users from adding it as a file extension
Side note, we could also add a custom icon for pnach files this way, but I don't feel like making icon artwork so I'm leaving it default.
Rationale behind Changes
Currently, when users try to rename text files to pnach files, macOS leaves the .txt extension and hides it instead of adding the new extension.
Suggested Testing Steps
- Try to rename a .txt file to .pnach in Finder with after unzipping PR's PCSX2. It should rename it without sneakily adding a hidden .txt
- Look at a .pnach file. It should have a text-document-looking icon with PNACH over it, instead of a blank generic unknown file icon.
Did you use AI to help find, test, or implement this issue or feature?
No
Do you need it separately for cheats as well, or maybe fine if you put PCSX2 Game Patch/Cheat as the identifier?
As even though it's internally the same where you modify memory addresses, users might not think they will work fine in either and just splitting it up intuitively for organisational purposes in the GUI for 2 different locations.
You can only have one name per file extension, so if both patches and cheats are .pnach, we can only give one name.
If cheats have a different extension, we need to add an entry for that as well.
You can only have one name per file extension, so if both patches and cheats are
.pnach, we can only give one name. If cheats have a different extension, we need to add an entry for that as well.
They are still .pnach files (patch and Nachbrenner author). So can't go that route then of 2 seperate entries. Was thinking when you try open a file it would have a different opening screen but seems Mac handles it differently.
Otherwise looks good. Will you add it as well for .zso , .mdf and .ps2 (memcards)? On that other PR? Probably there are some more that im not thinking about at the moment.
Was thinking when you try open a file it would have a different opening screen but seems Mac handles it differently.
There is no screen, it immediately opens the file. This is like the right click → Open With... option in Windows Explorer, not UI in PCSX2
The string appears in an optional column in Finder's detail view.