pcsx2 icon indicating copy to clipboard operation
pcsx2 copied to clipboard

SaveState: Improve version incompatibility error message

Open SternXD opened this issue 6 months ago • 3 comments

I did it because of this now closed issue https://github.com/PCSX2/pcsx2/issues/12753

Before: image

After: image

Description of Changes

Added version information to save state error messages to show users exactly which version of PCSX2 created the save state and which version they need to recover it. The error message now includes both the original version that created the save state and the current version being used.

Rationale behind Changes

Currently, when users try to load an incompatible save state, they have to guess which version of PCSX2 they need to recover their saves. By showing the exact version information, users can easily get the correct version of PCSX2 to recover their save states and transfer their progress to memory cards. This improves the user experience by removing the guesswork from save state recovery.

Suggested Testing Steps

  1. Create a save state using the current version of PCSX2
  2. Try to load this save state in a different version of PCSX2
  3. Verify that the error message shows:
  • The version that created the save state
  • The current version being used
  • Clear instructions about which version to download to recover the save

Did you use AI to help find, test, or implement this issue or feature?

I did not use it for my code but it did help me with grammar and better helping understand why this should be added

SternXD avatar May 31 '25 03:05 SternXD

It does help that it prints the current version, but the consistency of how it displays with or without or within the () feels like I've witnessed a crime (yeah, I know I'm exaggerating).

  1. PCSX2 current_version
  2. PCSX2 (current_version)
  3. (PCSX2 compatible_version)

But maybe it's just triggering my OCD and Japanese use nested quotes for easy detaching the title or variable in this case: 『 PCSX2 Version v2.3.300 』(there are tons of styling besides this but just an example)

RedDevilus avatar May 31 '25 03:05 RedDevilus

True yeah, I'll fix that real quick

SternXD avatar May 31 '25 03:05 SternXD

Otherwise, it looks fine to me. It's not exactly hard to read the code, but it is for the users. In future, we can always check to see if we should move it around like putting in newline for versions or not, but that's again going into what people prefer seeing it structured and less a direct improvement.

RedDevilus avatar May 31 '25 03:05 RedDevilus