Achievements: Add in-game leaderboard overlay toggle
Description of Changes
Adds a separate toggle for in-game leaderboard overlays, as suggested in #12676.
Rationale behind Changes
Being able to separately use achievement and leaderboard overlays, so that one can keep only the information they care about on the screen.
Suggested Testing Steps
Toggling both settings on and off and checking whether they correctly affect the overlays.
Did you use AI to help find, test, or implement this issue or feature?
No.
Might also be a good to make the commit to do something like Achievements:Add in-game leaderboard overlay toggle. Or hope while merging it's changed. I'll run workflows for now because it's your first time.
I accidentally opened the PR for the wrong branch, I fixed the commit there so that the description is correct.
While rebasing my changes, I noticed the notification position setting was in the wrong section, so I took the liberty to move it to the correct place and also to clarify in the help text that they apply to leaderboards as well.
If that's not appropriate, I can open a separate PR for it.
can this be rebased ?
Minor nitpick but since the locations of the overlays are now configurable, the description box should be updated accordingly.
Good catch, I changed the text to remove the reference to a specific position