pcsx2 icon indicating copy to clipboard operation
pcsx2 copied to clipboard

Achievements: Add in-game leaderboard overlay toggle

Open flavionm opened this issue 7 months ago • 2 comments

Description of Changes

Adds a separate toggle for in-game leaderboard overlays, as suggested in #12676.

Rationale behind Changes

Being able to separately use achievement and leaderboard overlays, so that one can keep only the information they care about on the screen.

Suggested Testing Steps

Toggling both settings on and off and checking whether they correctly affect the overlays.

Did you use AI to help find, test, or implement this issue or feature?

No.

flavionm avatar May 23 '25 02:05 flavionm

Might also be a good to make the commit to do something like Achievements:Add in-game leaderboard overlay toggle. Or hope while merging it's changed. I'll run workflows for now because it's your first time.

RedDevilus avatar May 23 '25 02:05 RedDevilus

I accidentally opened the PR for the wrong branch, I fixed the commit there so that the description is correct.

flavionm avatar May 23 '25 02:05 flavionm

While rebasing my changes, I noticed the notification position setting was in the wrong section, so I took the liberty to move it to the correct place and also to clarify in the help text that they apply to leaderboards as well.

If that's not appropriate, I can open a separate PR for it.

flavionm avatar Jul 27 '25 02:07 flavionm

can this be rebased ?

Mrlinkwii avatar Aug 03 '25 17:08 Mrlinkwii

Minor nitpick but since the locations of the overlays are now configurable, the description box should be updated accordingly.

image

kamfretoz avatar Aug 06 '25 01:08 kamfretoz

Good catch, I changed the text to remove the reference to a specific position

flavionm avatar Aug 06 '25 02:08 flavionm