PCSX2
USB: Dual Cursor Lightgun
Description of Changes
There seems to be an issue with how the MTGS handles the enumeration and drawing, updating for the replaced crosshairs icons that the users provides like in a .png format. Master would be random but tends to only show USB Device 1 crosshair. But now 2 at same time should work. Hopefully gets rid of https://github.com/PCSX2/pcsx2/issues/11423
Rationale behind Changes
The niche lightgun users also using niche dual replaced icons was certainly a bug as you get ghost inputs if not the texture was carefully drawn.
Suggested Testing Steps
Normal games work, but best in any game that uses GunCon2 aka lightgun games.
Did you use AI to help find, test, or implement this issue or feature?
No, this mess is my own.
Thanks for the PR! ❤️
It seems to work fine for me with any renderer but GL, when using GL I'm getting a crash on game start:
@bslenul Can you create a gs dump with a renderer that works where it would crash and post it here?
Sure, this is with "Automatic" (so VK in my case): gun-gs-dump.zip
The dump loads fine with all renderers expect GL (as long as I use at least 1 PNG as a crosshair).
It won't crash unless you've set a PNG crosshair, which I can't see on your screen.
Basically it looks like this for me with anything but GL (notice the crosshairs in the middle of the screen):
edit: Updated screenshot with OSD stuff.
Unrelated with that last change, but any idea why I'm getting this with this PR when running a Debug build?
Can confirm, no more crash with GL with that change! 👍
Argh, no more crash but now P2 cursor doesn't always appear again.
Can confirm, no more crash with GL with that change! 👍
Argh, no more crash but now P2 cursor doesn't always appear again.
Yup, if you have both crosshairs images with that fix in, it just reverts behaviour. Only shows first player crosshair and before showed both.
Is this also related to #4472
This doesn't touch firewire and iLink, those are just stubbed aka placebo files in the codes still so we don't do that functionality.
It's just visual indicators for custom crosshairs which doesn't affect in-game parts.
Is this also related to #4472
This doesn't touch firewire and iLink, those are just stubbed aka placebo files in the codes still so we don't do that functionality.
It's just visual indicators for custom crosshairs which doesn't affect in-game parts.
Ahh I see, thank you
With the latest changes PCSX2 hangs for me with custom crosshair PNG when launching a game in Big Picture mode.