pcsx2 icon indicating copy to clipboard operation
pcsx2 copied to clipboard

Debugger: Fix possible recursion loop when pause-on-tlb-miss is enabled

Open F0bes opened this issue 1 year ago • 4 comments

Description of Changes

The comment says it all. Essentially the pause handler in the debugger could cause a tlb miss, which would pause the VM again, which would call the pause handler in the debugger (you see a pattern?)

Rationale behind Changes

Patches the issue where resetting with pause-on-tlb-miss and the debugger enable could crash

Suggested Testing Steps

Enable pause-on-tlb-miss, open the debugger, and reset a bunch of times and see if PCSX2 crashes.

Fixes #11594

F0bes avatar Jul 19 '24 21:07 F0bes

It's still crashing :/

ghost avatar Jul 20 '24 00:07 ghost

It's still crashing :/

Can you show error and backtrace?

RedDevilus avatar Jul 20 '24 00:07 RedDevilus

I fixed the recursion, but you're right, the crash is still there.

The backtrace is quite odd, it's crashing inside of Qt. I'll have to further investigate.

F0bes avatar Jul 20 '24 00:07 F0bes

It's still crashing :/

Can you show error and backtrace?

I don't have a crash log.

https://github.com/user-attachments/assets/6c5db7aa-da49-4f0a-8494-af788a0a97a3

ghost avatar Jul 20 '24 00:07 ghost