pcsx2 PCSX2 Auto Test Suite

A nice guy create a test suite: a https://github.com/unknownbrackets/ps2autotests

I create a nice script to run test (elf) tests/run_test.pl

Here the remaining item to do

[x] add an help of the run_test.pl script
[ ] fix bad test (priority are the crash/timeout)
[x] add multiple configuration on the runner
[x] find a way to blacklist bad test until there are fixed
[ ] implement more test
[x] add iop test on the runner

~~find a way to run the test suite on buildbot (linux)~~

So who do what ? @ramapcsx2 @ssakash @refractionpcsx2 @turtleli

Jan 18 '16 19:01 gregory38

i think @ramapcsx2 has already got some of these to run and highlighted some issues that need looking in to, he has a VM that can compile them and tested them on PCSX2 vs a TEST console.

$refractionpcsx2 avatar$ Jan 18 '16 19:01 refractionpcsx2

actually I provided him a basic test runner so it used to run test in cygwin. The new test runner requires perl (I think it can work on cygwin too) but linux might be easier. (I mean for the PCSX2 part).

However you might be interested to add some tests. Which make me remember that cotton wrote a vu testsuite too??

Jan 18 '16 19:01 gregory38

I don't recall a test suite, i think some tests were done for testing VU oddities like multiple MUL's and ADD's in a row and getting the original answer or something ;p

$refractionpcsx2 avatar$ Jan 18 '16 19:01 refractionpcsx2

Is it possible to get/check all cotton post with an attachment on the forum?

Jan 18 '16 19:01 gregory38

not for me, i dont have database access, that will be something for Bosit to do, if he's available.

$refractionpcsx2 avatar$ Jan 18 '16 20:01 refractionpcsx2

@bositman we search a dev post of cotton with some attachment to run VU tests. If you have any hint.

Edit: or am I drinking too much !

Jan 18 '16 20:01 gregory38

@refractionpcsx2 Info on sysctrl test: Issue 1: infinte while loop in VifUnpackSSE_Dynarec::CompileRoutine

due to cl == wl == 0
so the else branch is always taken

Issue 2: Division by 0 because wl is 0

    if (!isFill) {
        // Accounting for skipping mode: Subtract the last skip cycle, since the skipped part of the run
        // shouldn't count as wrapped data.  Otherwise, a trailing skip can cause the emu to drop back
        // to the interpreter. -- Refraction (test with MGS3)
        uint skipSize  = (cl - wl) * 16;
        uint blocks    = v.block.num / wl;
        length += (blocks-1) * skipSize;
    }

Jan 18 '16 22:01 gregory38

If wl is 0 then the unpack won't work anyway, in filling write there has to be a WL, else nothing will be written. I guess we could bottle out of it completely, but that should never be the case.

I think there's a hack in unpack actually for a similar scenario that Kingdom Hearts does and that stops it doing stupid things.

Edit: yeh here it is

if ((vifXRegs.cycle.wl == 0) && (vifXRegs.cycle.wl < vifXRegs.cycle.cl)) { //DevCon.WriteLn("Vif%d CL %d, WL %d Mode %x Mask %x Num %x", idx, vifXRegs.cycle.cl, vifXRegs.cycle.wl, vifXRegs.mode, vifXRegs.mask, (vifXRegs.code >> 16) & 0xff); vifX.cmd = 0; return; // Skipping write and 0 write-cycles, so do nothing! }

I guess that could be modified to just say if wl == 0