pcsx2 icon indicating copy to clipboard operation
pcsx2 copied to clipboard

Qt: added Catppuccin Mocha theme

Open BPplays opened this issue 1 year ago • 11 comments

Description of Changes

added the Catppuccin Mocha theme

there are still some issue i don't know if can be fixed with just a theme:

  • the icons are not themed they are just white
  • the search bar text is not themed
  • seperators are not themed
  • non-highlighted outlines are not themed
  • check boxes are too low contrast
  • dropdown menus have gradients which doesn't look very good
  • some selection boxes with arrows on the side like emulation>maximum frame latency are also too low contrast
  • some sub-menus are weird colors like graphics>osd the box where the options are there looks odd
  • the window title on windows is not themed (this is probably not fixable) ​

also other Catppuccin flavors should also probably be added if mocha is

BPplays avatar Apr 15 '24 10:04 BPplays

Most of these are inherent to other themes already present so I wouldn't put too much weight into that. Besides that it looks great to me so I approve.

JordanTheToaster avatar Apr 15 '24 11:04 JordanTheToaster

Yeah, unfortunately palette changes are sometimes insufficient, and you need to use stylesheets.

Just have to be careful, because I've found styling some elements breaks the native popup dialogs on MacOS... :(

stenzek avatar Apr 15 '24 11:04 stenzek

~~im trying to make a qss theme and i've done a little with custom.qss but i would like to do an embeded qss theme if possible but im not really familiar with how i would add a file to the build system or reference it from the code. maybe it could go somewhere like ./resources/qss/CatppuccinMocha.qss?~~ i think i've got it working now

also i don't have a MacOS computer to test with

BPplays avatar Apr 24 '24 23:04 BPplays

I would also suggest, rechecking all elements. The contrast differences are pretty hard on the eyes on specific location.

For example: image

For a Darkish Palette, this is quite bright and even painful for light users.

RedDevilus avatar Apr 24 '24 23:04 RedDevilus

@RedDevilus if you're talking about the icon color i'll need to change the color when it's selected which i was already planning on doing. if you're talking about the light color with dark text then another option is to try and use one of the lighter grey colors in the theme instead of the bright accent color because all the the accent colors are decently bright

BPplays avatar Apr 24 '24 23:04 BPplays

im having trouble getting incremental builds to work in visual studio with this setup does anyone know why? there are also still quite a few issues with the theme

BPplays avatar Apr 25 '24 16:04 BPplays

im having trouble getting incremental builds to work in visual studio with this setup does anyone know why? there are also still quite a few issues with the theme

Join the Discord you can ask for help there.

JordanTheToaster avatar Apr 25 '24 16:04 JordanTheToaster

You'd have to be more specific. VS builds should just be a matter of downloading and extracting the deps pack, opening the solution, and clicking build. See https://github.com/PCSX2/pcsx2/wiki/12-Building-on-Windows

stenzek avatar Apr 25 '24 17:04 stenzek

@stenzek what i meant to say is that it won't do a build if i change the .qss file it doesn't seem to be keeping track of it, it only updates after a rebuild

BPplays avatar Apr 25 '24 18:04 BPplays

Oh, I see. Couple of suggestions then:

  1. Just hardcode a path on disk, that way you don't need to recompile.
  2. Or, right click resources.qrc, and click compile. IIRC this should force it to regenerate the cpp file. The dirty tracking in msbuild is a bit iffy, I've never bothered to look into if it can be improved..

stenzek avatar Apr 26 '24 02:04 stenzek

image

No need to add it as a resource. I added that bit ago to cover .qss files. Just name it Custom

Daisouji avatar Apr 28 '24 01:04 Daisouji

Let us know when you'll be working on this again and it can be re-opened. Closing for now because it has gone stale.

F0bes avatar Jul 28 '24 17:07 F0bes