pcsx2 icon indicating copy to clipboard operation
pcsx2 copied to clipboard

[Feature Request]: Removing of duplicate "Setting" line from the "System" tab

Open VladimirVSC opened this issue 1 year ago • 6 comments

Description

There are two "Settings" option line, which have completely similar functions: one is inside the "System" tab, and the second one is right next the "System' tab. The "system-tab-inside" one can be erased as useless.

Reason

Getting rid of the unnecessary duplicate option makes the interface more compact.

Examples

.

VladimirVSC avatar Jan 30 '24 17:01 VladimirVSC

Could you please describe the request better? maybe even take some pictures, cuz right now its not very clear what you mean :b

AmandaRoseChaqueta avatar Feb 05 '24 01:02 AmandaRoseChaqueta

Could you please describe the request better? maybe even take some pictures, cuz right now its not very clear what you mean :b

Sorry for not making a picture. I was talking about this...

Screenshot 2024-02-08 11:30:20

VladimirVSC avatar Feb 08 '24 08:02 VladimirVSC

~~These are not duplicates, the one in System is for PCSX2 specific settings (which makes sense to be under system IMO) and the Settings menu to the right is for game specific settings, which is an entirely different set of menus/configuration. The only redundancy is in naming.~~

Sorry, it's morning.

Daniel-McCarthy avatar Feb 08 '24 13:02 Daniel-McCarthy

These are not duplicates, the one in System is for PCSX2 specific settings (which makes sense to be under system IMO) and the Settings menu to the right is for game specific settings, which is an entirely different set of menus/configuration. The only redundancy is in naming.

actually the settings menu is the global settings, unless you choose "game properties", then it goes to the per-game settings.

So technically it is duplicated, yeah

refractionpcsx2 avatar Feb 08 '24 13:02 refractionpcsx2

Apparently the settings button in the "System" tab is required for macOS users, see commit 7a4ef32210a6a25aa47e17c19ed5e55f93adc3aa and #8360

OnlyVoidd avatar Jun 17 '24 10:06 OnlyVoidd

For reference, there is a slight difference between that settings button and the ones in the settings menu.

The settings button opens the settings pane to the last viewed section, rather than jumping to a specific section like the ones in the settings dropdown do. This is the expected functionality of the macOS preferences menu option, which is why I wasn't able to grab one of the existing settings menu entries to make the macOS button. There is a button with that function in the toolbar, but macOS needs it in the menu system.

If you want to put it somewhere else or rename it, you can do so as long as it stays within the menu system (IIRC Qt will automatically move it into the application menu and give it the expected Preferences... name for you on macOS). I just couldn't think of a decent name to give the generic settings option if I was going to put it into the settings dropdown, so I put it into the file dropdown instead.

TellowKrinkle avatar Jun 20 '24 08:06 TellowKrinkle