pcmdi_metrics icon indicating copy to clipboard operation
pcmdi_metrics copied to clipboard

Simplify PMP JSON contents

Open lee1043 opened this issue 2 years ago • 9 comments

Current PMP output json files have heavy contents (e.g., Mean clim, MoV). In effort to reduce the file size for regular online archive, one possibility is to not include "YAML" and "script" as default.

I think this could be handled by revising base.py in pcmdi_metrics/io directory, maybe by adding if statement for this line of the code, so storing YAML info can be optional.

lee1043 avatar Sep 06 '22 16:09 lee1043

@acordonez would you mind helping on this when you have time?

lee1043 avatar Sep 06 '22 16:09 lee1043

@lee1043 Yes I'll start taking a look at this

acordonez avatar Sep 06 '22 17:09 acordonez

@acordonez, I got this handled in this commit, as a part of PR for cloud metric, so no worries.

I am yet to test its influence to the cmec flag, presume there should be no impact. @acordonez any thoughts?

lee1043 avatar Sep 22 '22 01:09 lee1043

@lee1043 It shouldn't have any effect on the cmec flag operation, but I'll give it a test

acordonez avatar Sep 22 '22 15:09 acordonez

I tried out the monsoon_wang and enso drivers with the new changes. They don't include the YAML or scripts by default. The enso flag worked fine with monsoon_wang.

acordonez avatar Sep 22 '22 17:09 acordonez

@acordonez thank you for checking this. I believe you meant "cmec" flag worked fine with monsoon_wang and enso driver, is that right?

lee1043 avatar Sep 22 '22 17:09 lee1043

@lee1043 I don't think we've implemented the "cmec" flag with enso driver - I get an "unrecognized argument" error when I add it in, and I don't see it in the driver code.

acordonez avatar Sep 22 '22 17:09 acordonez

@acordonez right, thanks for clarifying. I just got confused because you mentioned enso in your comment

I tried out the monsoon_wang and enso drivers with the new changes. They don't include the YAML or scripts by default. The enso flag worked fine with monsoon_wang.

lee1043 avatar Sep 22 '22 17:09 lee1043

@lee1043 Oh I see, my brain kept skipping over my own typo! Yes, the cmec flag.

acordonez avatar Sep 22 '22 17:09 acordonez