facets icon indicating copy to clipboard operation
facets copied to clipboard

Add support for log scale in dive

Open Mortimerp9 opened this issue 8 years ago • 4 comments

for numerical features with very wide ranges, it would be useful to be able to use different scale when binning. A contrived example can be see in that screenshot:

screen shot 2017-08-09 at 5 04 52 pm

Mortimerp9 avatar Aug 09 '17 07:08 Mortimerp9

Thanks for the feature request. We've heard this request before and agree it would be very valuable.

Do you have any interest in creating a pull request that adds a "log scale" checkbox to dive?

jameswex avatar Aug 11 '17 14:08 jameswex

okay, I tried to understand the code, but some pointers to where to look at this would be good.

Mortimerp9 avatar Aug 16 '17 04:08 Mortimerp9

You would need to add a checkbox below the faceting paper-dropdown-menus when the user selects a numeric column to facet in facets_dive/components/facets_dive_controls/facets-dive-controls.html along with a property in the corresponding ts file like "verticalFacetLogScale: boolean;" to set when the checkbox is set/unset.

That checkbox setting would need to be used by/provided to facets_dive/components/facets_dive_vis/facets-dive-vis.ts generateNumericFacetingInfo method which buckets the values for a feature into the individual buckets.

If you aren't comfortable with polymer / typescript / this code then it is something we will eventually get to.

jameswex avatar Aug 17 '17 18:08 jameswex

I ll be happy to do it, I just got lost in the vis code. Your pointers are going to make it a lot faster to implement. Thanks

On Aug 17, 2017 11:17, "James Wexler" [email protected] wrote:

You would need to add a checkbox below the faceting paper-dropdown-menus when the user selects a numeric column to facet in facets_dive/components/facets_dive_controls/facets-dive-controls.html along with a property in the corresponding ts file like "verticalFacetLogScale: boolean;" to set when the checkbox is set/unset.

That checkbox setting would need to be used by/provided to facets_dive/components/facets_dive_vis/facets-dive-vis.ts generateNumericFacetingInfo method which buckets the values for a feature into the individual buckets.

If you aren't comfortable with polymer / typescript / this code then it is something we will eventually get to.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/PAIR-code/facets/issues/48#issuecomment-323152921, or mute the thread https://github.com/notifications/unsubscribe-auth/AAmW82TOIj5dKgN1lIC7YvkVEeVXkOFCks5sZIOwgaJpZM4Oxrb6 .

Mortimerp9 avatar Aug 17 '17 19:08 Mortimerp9