facets icon indicating copy to clipboard operation
facets copied to clipboard

Published 20 hours ago • verified publisher icon PAIR-code

Create standalone facets-dive component

Open JaySunSyn opened this issue 6 years ago • 3 comments

I'm suggesting to extract the facets-dive component into a new repository. And then install it as a dependency in facets. I can create PRs for that.

Advantages:

  • Polymer standard => easier to contribute
  • Polymer standard => easier to reuse
  • Live reload => more efficient development
  • Easier building and testing => better code quality
  • Easier to upgrade to e.g. Polymer 2

What do you think? :-)

JaySunSyn avatar May 08 '18 02:05 JaySunSyn

A bit related https://github.com/PAIR-code/facets/issues/84

JaySunSyn avatar May 09 '18 01:05 JaySunSyn

What changes were you thinking of making in addition to just separating the two visualizations into separate repos? I'd like to see a rundown of the proposed code and directory-structure changes.

jameswex avatar May 11 '18 18:05 jameswex

Would you want to stay with Typescript even though we separate the component? If yes, I'll try some things with Webpack and Polymer 3. If no, it'll be much easier.

Please let me know and I'll post details asap

JaySunSyn avatar May 16 '18 05:05 JaySunSyn