simulator
simulator copied to clipboard
P2PSP
Peer added to the graph again even after removing from the team
Even after removing from the team, some peers are adding again in the graph while plotting. Console shows that peer have been removed from the graph but it doesn't.
@cristobalmedinalopez A quick solution would be to put NODE OUT line in drawing file whenever a peer receives good bye message from the splitter. Also, respond to request message if and only if the sender is in peer list.
@cristobalmedinalopez, is there any scenario when above solution would fail?
What should we do for following scenario:
When peer receives a request messaege from removed peer before receiving good bye message from the splitter.
if we follow this solution:
@cristobalmedinalopez A quick solution would be to put NODE OUT line in drawing file whenever a peer receives good bye message from the splitter. Also, respond to request message if and only if the sender is in peer list.
then removed peer would appear for time until it don't receives a good bye message.
A quick solution would be to put NODE OUT line in drawing file whenever a peer receives good bye message from the splitter.
You mean it removes itself, isn't it?
Also, respond to request message if and only if the sender is in peer list.
Yes, it sounds good!
When peer receives a request messaege from removed peer before receiving good bye message from the splitter (edited).
Does that action trigger the writing of a NODE IN line in the drawing file?
Does that action trigger the writing of a NODE IN line in the drawing file?
yes, whenever a peer receives a request message from another peer, and if it is not in the forwarding list of origin (of requested chunk), then it write NODE IN for sender in drawing file, that's the cause of this bug. This would overwrite splitter's action of NODE OUT.
A quick solution would be to put NODE OUT line in drawing file whenever a peer receives good bye message from the splitter.
You mean it removes itself, isn't it?
No, i was talking in reference to other peers who will receive GOODBYE message from removed peers.
No, i was talking in reference to other peers who will receive GOODBYE message from removed peers.
It could work with honest peers.
Even if every peer put NODE OUT on receiving GOODBYE message, even then removed peer may appear in network overlay for a tiny interval of time (like a ghost). Because a peer may receive request message before goodbye message. Do you @cristobalmedinalopez think we can do something with that, because possibility seems very low ?
Even checking sender in peer_list before responding to request_chunk message will not work due to above reason.
I think it's not an important issue that removed peers appear like a ghost if finally they are completely removed from the graph. What do you think @vicente-gonzalez-ruiz? Any other idea @josmanual?
@cristobalmedinalopez , how should we check if removed peer is in peer_list or not, as we just have a forwarding list? should we check this peer in every forwarding list ?
No, I think it would be enough checking the forwarding list of itself (where it is the origin).