terraguard icon indicating copy to clipboard operation
terraguard copied to clipboard

Published 20 hours ago • verified publisher icon P0ssuidao

feat: add oci provider deployment

Open omurilo opened this issue 1 year ago • 4 comments

Add a Oracle Cloud Infrastructure as provider to deployment terraguard

omurilo avatar Jan 22 '24 16:01 omurilo

I've created a pull request on your branch with some minor fixes. The details are as follows:

The declaration of the variable availability_domain with the number type enables the project to be used in accounts with limited resource availability. Free accounts have resource limitations based on availability domains (AD).

  • README.md [X] Modified the oci session authenticate command to use sudo in accordance with project requirements. [X] Added TF_VAR for region and availability domains, making it easier to apply in other regions. [X] Added instructions to run the sudo terraform -E command for the use of previously exported TF_VAR.

  • modules/.../variables.tf [X] Refactored for use with modules

  • variables.tf [X] Added the variable availability_domain and removed the default field in the region variable. [X] Refactored for use with modules

  • modules/instance/main.tf [X] Implementation of the availability_domain variable.

  • .gitignore [X] Added **/.terraform* to the .gitignore file.

Rapha-Borges avatar Jan 23 '24 23:01 Rapha-Borges

I've created a pull request on your branch with some minor fixes. The details are as follows:

The declaration of the variable availability_domain with the number type enables the project to be used in accounts with limited resource availability. Free accounts have resource limitations based on availability domains (AD).

* README.md
  [X] Modified the `oci session authenticate` command to use sudo in accordance with project requirements.
  [X] Added `TF_VAR` for region and availability domains, making it easier to apply in other regions.
  [X] Added instructions to run the `sudo terraform -E` command for the use of previously exported `TF_VAR`.

* modules/.../variables.tf
  [X] Refactored for use with modules

* variables.tf
  [X] Added the variable `availability_domain` and removed the `default` field in the `region` variable.
  [X] Refactored for use with modules

* modules/instance/main.tf
  [X] Implementation of the `availability_domain` variable.

* .gitignore
  [X] Added `**/.terraform*` to the `.gitignore` file.

LGTM, only comment about availability var number

omurilo avatar Jan 25 '24 15:01 omurilo

LGTM, only comment about availability var number

Fixed!

Once you make the proposed changes, I believe it will be ready for the merge.

I successfully tested it on three different accounts.

Rapha-Borges avatar Jan 25 '24 15:01 Rapha-Borges

@P0ssuidao has any issue about this PR?

omurilo avatar May 25 '24 18:05 omurilo