Auxio icon indicating copy to clipboard operation
Auxio copied to clipboard

Tolerate inconsistent MusicBrainz ID usage

Open alphanerdgen opened this issue 1 year ago • 13 comments

Describe the Bug/Crash

Under the 'Artists' tab, Auxio's creating multiple entries for some artists in spite of them having the correct tags. I checked a track's properties and found that the artist's name is getting added again in the 'Artists' field within parentheses. This issue isn't occuring in other music players.

Screenshot_Auxio 1

Screenshot_Auxio 2

Screenshot_Auxio 3

Intelligent sorting is enabled.

Version: 3.2.0 [F-Droid]

Describe the intended behavior

The app shouldn't duplicate tag details.

What android version do you use?

Android 12

What device model do you use?

Samsung Galaxy

Bug report

No bug report.

Duplicates

alphanerdgen avatar Aug 29 '23 16:08 alphanerdgen

This is caused by your music library partially using MusicBrainz IDs (MBIDs). Auxio considers artists without MBIDs and artists with MBIDs to be different, and groups them separately. There's not really a better behavior I can use regarding this without causing more subtle bugs, so I just go with the strategy that results in the most obvious indicator that your library is tagged wrong.

If I were to guess at the cause, this is because you've used two different taggers. One is applying information from MusicBrainz, including MBIDs and sort names (Which is what you are seeing with artists like "Godsmack (Godsmack)". I should probably make that clearer...). One applies more basic tag information.

I would highly recommend either removing all MusicBrainz IDs from your library, or using an autotagger like Picard or Beets that will universally apply MBID information.

OxygenCobalt avatar Aug 29 '23 16:08 OxygenCobalt

@OxygenCobalt Yeah, I did use two different taggers (MB Picard and Mp3tag). Removing the MBIDs fixed the issue.

Thanks for the quick reply and this beautiful app.

alphanerdgen avatar Aug 29 '23 19:08 alphanerdgen

Now that I think about it, it could actually be possible to handle inconsistent MBIDs better without bugs if I were to tweak the music grouping algorithm. I'll re-open to investigate.

OxygenCobalt avatar Aug 30 '23 02:08 OxygenCobalt

i think this would be good. The benefit of seeing incorrect tags is great, but i think a setting that ignores them would be very useful (for when you know some stuff is incorrectly tagged, but don't have time to fix it, and now can't properly play one album or something because half the stuff is in another artist entry)

KraXen72 avatar Sep 03 '23 13:09 KraXen72

I honestly don't see myself doing that @KraXen72 here. My workaround should not have any secondary issues hopefully.

OxygenCobalt avatar Sep 03 '23 16:09 OxygenCobalt

so auxio will be able to merge artists without MBID's and artists with MBID's?

KraXen72 avatar Sep 03 '23 17:09 KraXen72

Yes, my idea is that with some changes I would be able to gracefully degrade if MBID usage is inconsistent @KraXen72. If the app finds that a given artist name corresponds to a null MBID and a non-null MBID, it will simply move the songs from the null MBID to the songs with a non-null MBID. My reasoning is that even though this increases the risk of merging different artists with the same name, someone already aware of that should be tagging appropriately anyway, so it shouldn't affect them.

OxygenCobalt avatar Sep 03 '23 17:09 OxygenCobalt

ah, that's a great idea. what about the scenario where 2 artists (let's say A and B) have several songs and the same display name (there are over 20 artists with the name Atlas, for example). If these artists have a different MBID, but some songs don't have a mbid, where will they go?

KraXen72 avatar Sep 03 '23 17:09 KraXen72

My reasoning is that even though this increases the risk of merging different artists with the same name, someone already aware of that should be tagging appropriately anyway, so it shouldn't affect them.

ah okay. i guess my question is an edge-case then. I am still interesting in the resolution logic though.

KraXen72 avatar Sep 03 '23 17:09 KraXen72

what about the scenario where 2 artists (let's say A and B) have several songs and the same display name (there are over 20 artists with the name Atlas, for example). If these artists have a different MBID, but some songs don't have a mbid, where will they go?

They will be moved to the artist with the most songs @KraXen72. This is to reduce the likelihood I'm merging into the wrong artist, as I'd imagine that the artist with a lot of songs is the one more likely to be inconsistent compared to one that has a few songs.

OxygenCobalt avatar Sep 03 '23 17:09 OxygenCobalt

As my bug has been closed as duplicate of this one: what is described there seems NOT to be the reason for my troubles. All filed have been tagged with the same version of MusicBrainz Picard. On the other hand: the only visible difference between the two "Oxygene Trilogy" albums is the date. In my opinion it does not make sense to use this date as sorting criteria.

Elmi77 avatar Sep 22 '23 10:09 Elmi77

As my bug has been closed as duplicate of this one: what is described there seems NOT to be the reason for my troubles. All filed have been tagged with the same version of MusicBrainz Picard. On the other hand: the only visible difference between the two "Oxygene Trilogy" albums is the date. In my opinion it does not make sense to use this date as sorting criteria.

Elmi77 avatar Sep 22 '23 10:09 Elmi77

As my bug has been closed as duplicate of this one: what is described there seems NOT to be the reason for my troubles. All filed have been tagged with the same version of MusicBrainz Picard. On the other hand: the only visible difference between the two "Oxygene Trilogy" albums is the date. In my opinion it does not make sense to use this date as sorting criteria.

Elmi77 avatar Sep 22 '23 10:09 Elmi77