OxygenCobalt
Enable theme customization on Android 12+
Describe the feature you want to implement:
Add an option to enable dark/light theme independent of OS setting.
Is your feature request related to a problem? Please describe:
Do other music players handle this? If so, how?
A lot of other apps provide a option to override theme to dark, light or system.
Why do you think this will improve everyone's usage of Auxio?
Due Diligence:
- [x] I have read the Contribution Guidelines.
- [x] I have read the Accepted Additions and Requests document.
- [x] I have checked for this feature in the FAQ.
I'm going to assume you are on Android 12+. This setting is implemented below Android 12, but I disabled it on newer versions. My logic is that the picker is only useful if your OEM does not implement a global toggle and you must do it app-by-app, but that shouldn't really occur anymore beyond 12.
Is there any other benefit besides that other apps have it? I usually don't implement X because other apps have X and nothing else.
only having a system wide toggle is quite unpleasant, as some apps appear a lot nicer in the opposite theme, or can be much less usable in the chosen theme for everything else (sygic dark mode is awful for example, difficult to read maps in, which for a navigation app is a fatal flaw). in that sense i am glad to not be on android 12
Okay, that's reasonable. I'll go add it, is only maybe a 3 line change.