ERST: Tomcat relative oxalis home
Pull Request Description
Erhvervsstyrelsen (ERST) has implemented a Tomcat relative property home detector. It takes a property RELATIVE_OXALIS_HOME and detects that path relative to the Tomcat catalina.base property.
This is very useful for us because we place the oxalis home folder in the same location within the Tomcat folder. The absolute path to the Tomcat folder may vary across different environments or on developers' computers, making it inconsistent.
See change here: https://rep.erst.dk/git/openebusiness/nemhandeledelivery/oxalis/-/blob/master/oxalis-commons/src/main/java/dk/erst/oxalis/commons/filesystem/detector/RelativePropertyHomeDetector.java
Type of Pull Request
- [X] New feature/Enhancement - non-breaking change which adds functionality
- [ ] Bug fix
- [ ] Breaking change (Require Major version change?)
Type of Change
- [ ] OpenPeppol AS2/AS4 specification
- [ ] OpenPeppol Spring/Fall release
- [X] Oxalis software change or enhancement
- [ ] CEF change
Pull Request Checklist:
- [X] My code follows the style guidelines of this project
- [X] I have commented my code, particularly in hard-to-understand areas. But did not added unnecessary annotation/comment say @author name etc
- [X] I have checked my code for variable and method name and corrected grammar/spelling mistakes if any
- [X] I have made corresponding changes to the documentation where needed
- [X] My changes generate no new/additional warnings
- [X] My change is not breaking or creating conflict with associated dependencies
- [X] I have performed a self-review of my own code
- [X] I ran
mvn clean installbefore commit and all tests run successfully - [X] I conducted basic QA to assure all features are working fine
- [X] My pull request generate no conflicts with
masterbranch - [ ] I requested code review from other team members
As you maybe noticed, 2 other changes in Oxalis I have already copied from ERST code base - described in the task https://github.com/OxalisCommunity/oxalis/issues/623 and https://github.com/OxalisCommunity/Oxalis-AS4/issues/206 with linked pull requests. This change I evaluated and found out, that it can reside in the nemhandel "extension" - so it is not critical to include it into the main code base. But I requested @aaron-kumar to review this change request.