biobankAccelerometerAnalysis icon indicating copy to clipboard operation
biobankAccelerometerAnalysis copied to clipboard

Refactor plotting

Open angerhang opened this issue 3 years ago • 4 comments

At the moment, the plotting script is a big script clotting together which makes it more cumbersome than ideal to make changes or add features. We need to refactor this badly.

https://github.com/activityMonitoring/biobankAccelerometerAnalysis/blob/master/accelerometer/accPlot.py

angerhang avatar Nov 02 '21 20:11 angerhang

I agree 👍

chanshing avatar Nov 03 '21 13:11 chanshing

@angerhang Would you like to look at accPlot again and have a go? Or @R-Walmsley if interested.

chanshing avatar Oct 07 '22 02:10 chanshing

I know @gmertes is also using this function so cc'ing in case you've already made any changes to your own version.

R-Walmsley avatar Oct 07 '22 08:10 R-Walmsley

My changes are already merged. My only request is to keep the interface to plotTimeSeries the same (or at least backwards compatible), that's the function I'm using.

gmertes avatar Oct 07 '22 11:10 gmertes

Re-open if unresolved.

chanshing avatar Mar 01 '23 15:03 chanshing