SportBukkit icon indicating copy to clipboard operation
SportBukkit copied to clipboard

Fix maxNoDamageTicks being cut in half

Open jedediah opened this issue 10 years ago • 4 comments

For no apparent reason, noDamageTicks was counting down from maxNoDamageTicks to maxNoDamageTicks/2. Both of these values can be set through the Bukkit API, but there is no correction for this strange offset. As a result, the value passed to setMaxNoDamageTicks would effectively be cut in half, and the value passed to setNoDamageTicks would be reduced by maxNoDamageTicks/2.

jedediah avatar Aug 28 '14 04:08 jedediah

Missing two // CraftBukkit comments

tonybruess avatar Aug 28 '14 04:08 tonybruess

added comments

jedediah avatar Aug 28 '14 04:08 jedediah

Looks good to merge

ttaylorr avatar Aug 28 '14 06:08 ttaylorr

One thing. Bukkit/CraftBukkit@bccc961ddf29fa2c9463e5648fc425a78fa4a7b5 changed the damage API and mentioned the changes affecting noDamageTicks. Not sure exactly what they did, but would it be better to update SportBukkit? I updated it a while ago but it caused issues with our kill tracking.

tonybruess avatar Aug 28 '14 16:08 tonybruess