SportBukkit icon indicating copy to clipboard operation
SportBukkit copied to clipboard

Published 20 hours ago • verified publisher icon OvercastNetwork

Fix addItem method in CraftInventory

Open cswhite2000 opened this issue 7 years ago • 5 comments

In the CraftInventory class the firstEmpty method, called by addItem, wasn't working correctly. This caused the addItem method to only add items to stacks that already had the item. This fixes //wand not working in worldedit and /give not working in commandbook.

cswhite2000 avatar May 03 '17 01:05 cswhite2000

You should take a look at https://github.com/OvercastNetwork/SportBukkit/blob/master/CraftBukkit/Reduce-ItemStack-copying.patch#L258 ,we don't want a new patch to fix an older one, just edit the older one instead

Pablete1234 avatar May 03 '17 16:05 Pablete1234

I moved the fix to the Reduce-ItemStack-copying patch

cswhite2000 avatar May 03 '17 22:05 cswhite2000

Did you run this thru the scripts? shouldn't it also edit the CB snapshot?

Pablete1234 avatar May 04 '17 12:05 Pablete1234

I guess I forgot to run rake snapshot. It should be fixed now.

cswhite2000 avatar May 04 '17 14:05 cswhite2000

And yes, I did run it through the scripts.

cswhite2000 avatar May 06 '17 01:05 cswhite2000