package_rename icon indicating copy to clipboard operation
package_rename copied to clipboard
verified publisher icon OutdatedGuy

Feat: Add support custom_dir_path

Open malvinpratama opened this issue 4 months ago • 3 comments

I am not good for documentation. But this PR is for support melos/microfrontend. So, we can set where the output file will generated. For now only support on android & ios

malvinpratama avatar Aug 26 '25 16:08 malvinpratama

Hi @malvinpratama thanks for the PR, I see you have added an additional key to specify custom directory path, but it seems to be not implemented for every function (in android and ios) i.e. Implemented for _setAndroidAppName and _setAndroidPackageName but not for _createNewMainActivity in android.

Also I was not able to run this implementation successfully on my side. Can you add some configuration details that I need to know?

P.S. Marking this PR as draft.

OutdatedGuy avatar Aug 29 '25 10:08 OutdatedGuy

Hi @malvinpratama thanks for the PR, I see you have added an additional key to specify custom directory path, but it seems to be not implemented for every function (in android and ios) i.e. Implemented for _setAndroidAppName and _setAndroidPackageName but not for _createNewMainActivity in android.

Also I was not able to run this implementation successfully on my side. Can you add some configuration details that I need to know?

P.S. Marking this PR as draft.

@OutdatedGuy Sorry I forgot to commit that. Please check again

malvinpratama avatar Aug 31 '25 01:08 malvinpratama

Hi @malvinpratama, the errors are now gone, but I still need help setting up melos. Can you help me with that for testing?

OutdatedGuy avatar Aug 31 '25 10:08 OutdatedGuy