CefGlue icon indicating copy to clipboard operation
CefGlue copied to clipboard

Avalonia 11 upgrade

Open joaompneves opened this issue 1 year ago • 5 comments

joaompneves avatar Apr 09 '23 21:04 joaompneves

@joaompneves I really appreciate, that you took a look at this, thank you.

I hope you don't mind me asking a question, because I don't understand what you are doing here:

_current = Observable.Interval(TimeSpan.FromMilliseconds(delayMs)).ObserveOn(AvaloniaScheduler.Instance).Subscribe((i) => {
    CefRuntime.DoMessageLoopWork();
});

It feels a little weird to me adding the whole Avalonia.ReactiveUI Dependency only for supporting this small piece of code. I personally switched from Avalonia.ReactiveUI to CommunityToolkit.Mvvm and while it would not be a real problem to use ReactiveUI, maybe this can be solved without being a mandatory dependency?

sandreas avatar Apr 10 '23 07:04 sandreas

@joaompneves I really appreciate, that you took a look at this, thank you.

I hope you don't mind me asking a question, because I don't understand what you are doing here:

_current = Observable.Interval(TimeSpan.FromMilliseconds(delayMs)).ObserveOn(AvaloniaScheduler.Instance).Subscribe((i) => {
    CefRuntime.DoMessageLoopWork();
});

It feels a little weird to me adding the whole Avalonia.ReactiveUI Dependency only for supporting this small piece of code. I personally switched from Avalonia.ReactiveUI to CommunityToolkit.Mvvm and while it would not be a real problem to use ReactiveUI, maybe this can be solved without being a mandatory dependency?

I'm just trying to make it work, and the AvaloniaScheduler moved to that package, that's why I imported it. Most important this is still not working.

joaompneves avatar Apr 10 '23 08:04 joaompneves

It's now displaying. Regarding your previous comment, Avalonia.ReactiveUI is a very small dependency, and essential for CefGlue to work on mac. CommunityToolkit.Mvvm is not the same thing.

joaompneves avatar Apr 10 '23 08:04 joaompneves

The package is now available.

joaompneves avatar Apr 10 '23 09:04 joaompneves

Is there anything I could do to support this PR? Would be great to get it merged :-)

ITDancer13 avatar Nov 25 '23 18:11 ITDancer13