BandcampDownloader icon indicating copy to clipboard operation
BandcampDownloader copied to clipboard

Support tracks with custom cover art

Open TadEro opened this issue 7 years ago • 15 comments

There are some songs that have a custom cover art. The program sometimes applies them to their respective songs, and sometimes no. The right thing would be to always apply it, I guess.

TadEro avatar Feb 17 '18 05:02 TadEro

Can you provide an example URL?

Otiel avatar Feb 17 '18 08:02 Otiel

Oh okay, no problem.

Let's see, there's the Homestuck vol. 1-4 album. It has this cover art. The third track, Showtime (Original Mix), for instance, has this cover, wich is different from the album's.

Hope that helps!

TadEro avatar Feb 18 '18 02:02 TadEro

Thanks, I'll have a look at it.

Otiel avatar Feb 19 '18 12:02 Otiel

Okay! I hope you can implement it.

TadEro avatar Feb 20 '18 04:02 TadEro

I... I am still waiting for an update or something! :P

TadEro avatar Mar 14 '18 22:03 TadEro

I think the unwritten standard is to have a unique cover art for all songs of an album because the cover art replaces the album cover used on the front of a packaging audio product. I'm not too kind in changing the current way of doing.

The program sometimes applies them to their respective songs, and sometimes no.

Do you mean that BandcampDownloader sometimes saves a different cover art for some songs? Because it's not supposed to, and I couldn't reproduce it with the URL you provided.

Otiel avatar Mar 16 '18 21:03 Otiel

Well what I meant with that is, some songs have a different cover art than the "base" one. What I also meant is that it's not the .jpg file of the album cover, but the individual cover each song has.

Here's another example; every track of this album has a different cover: Cherubim I can give more if you'd like

TadEro avatar Mar 17 '18 03:03 TadEro

With this example Cherubim, only the album cover art is downloaded and tagged into each song. So BandcampDownloader behaves as it is supposed to.

I guess your sentence quoted below confused me, because I thought you were reporting a bug:

The program sometimes applies them to their respective songs, and sometimes no.

So are you reporting a bug, or are you just asking for a new feature that allows to download the individual songs cover art?

Otiel avatar Mar 17 '18 11:03 Otiel

well, technically both, since it doesn't work well. but yeah, it's a request. it would make me really happy to have this!

TadEro avatar Mar 17 '18 17:03 TadEro

Alright, I'll look into adding an option to download tracks art instead of the unique album art. 👌

Otiel avatar Mar 17 '18 19:03 Otiel

oh yes! thank you very much!

TadEro avatar Mar 17 '18 23:03 TadEro

@TadEro So the current way things are working on bandcamp, they essentially spit out a very easy-to-parse JSON string on most pages containing metadata about songs. This is how we get download links, title, lyrics, etc. When checking your example of a song with differing art, I couldn't find any property that would help us fetch the art. What this means is that doing what you are asking will likely require a much different approach, code-wise. @Otiel , can you double-check for me to confirm what I'm saying?

ajsnyde avatar Mar 24 '18 14:03 ajsnyde

@ajsnyde There's no JSON property on the album page that links to the track art, but there is one on the track page, so we could do:

  1. Get track URL from album page (via title_link property).
  2. Download track page.
  3. Inside TralbumData variable of track page, get art_id property.
  4. Download track art (it's basically https://f4.bcbits.com/img/a[art_id]_10.jpg).

The drawback I see from this is we would need to download every track page (we don't know the need to download the track page because we can't even know in advance if the track art is different from the album art), and that will take a lot (I mean, a lot) more time.

Otiel avatar Mar 26 '18 15:03 Otiel

That was what I was worried about. Well, maybe I'll add something like that if I've got time.

ajsnyde avatar Mar 26 '18 23:03 ajsnyde

Would be nice, if BD could download originals of all additional artwork on page and also individual track images, even if takes a lot time to analyze. Take a look at this page and tracks - there are a lot of additional images: https://s1gnsofl1fe.bandcamp.com/album/language-of-the-ancients

I don't think you should add individual track images in tags, only the main image.

DarkVoyage avatar May 17 '23 12:05 DarkVoyage