doctor-rst icon indicating copy to clipboard operation
doctor-rst copied to clipboard

A rule or rule type should be able to configure if the content of the line is shown

Open OskarStark opened this issue 3 years ago • 1 comments

Maybe this should be implemented after: https://github.com/OskarStark/doctor-rst/issues/825

Currently we show the line content for all rules/types: CleanShot 2020-11-21 at 15 52 01

However this makes no sense for the rules introduced in: https://github.com/OskarStark/doctor-rst/pull/824

We should use Line number 0 like now to be able to annotate on Github, but showing the content of this line 0 is confusing.

OskarStark avatar Nov 21 '20 14:11 OskarStark

I think is now possible with the Violation object. When rawLine is empty line is not displayed

https://github.com/OskarStark/doctor-rst/blob/d16c1de24fca817d90155b5546713189f7b7603f/src/Formatter/ConsoleFormatter.php#L92-L94

alamirault avatar Apr 28 '23 18:04 alamirault