django-nested-inline icon indicating copy to clipboard operation
django-nested-inline copied to clipboard

Fixing Inlines displaying as Editable

Open gascarcella opened this issue 5 years ago • 5 comments

Fixed Inlines displaying as Editable on Read Only view.

We still need to get rid of the add buttons

image

@OskarPersson i hope you can take a look. I'll have some time to work on this tomorrow

gascarcella avatar Feb 21 '20 13:02 gascarcella

Thank you, I will look into this when I can. Also, if you want to update an existing pull request without creating a new one you can simply push to your own branch again and it will automatically be updated.

OskarPersson avatar Feb 21 '20 14:02 OskarPersson

Thank you, I will look into this when I can. Also, if you want to update an existing pull request without creating a new one you can simply push to your own branch again and it will automatically be updated.

Thanks and sorry for closing the last one! 1st time contributing to open source

gascarcella avatar Feb 21 '20 14:02 gascarcella

@gascarcella I updated your branch. I have managed to get rid of the add button. The delete checkbox is still there in the upper-right, but you can't do anything with it since the save button is not there any more. Tell me if this works for you or not :)

OskarPersson avatar Feb 21 '20 22:02 OskarPersson

@gascarcella Have you had any time to look into my updates?

OskarPersson avatar Mar 05 '20 14:03 OskarPersson

Hey @OskarPersson . I'm really sorry, im busy on another project until tomorrow. I'll have time Saturday and Sunday, and will post you an update asap.

We keep in touch

gascarcella avatar Mar 05 '20 19:03 gascarcella