Osiris-Team

Results 157 comments of Osiris-Team

Btw, there would be breaking changes for gradle users at least, so maybe this should be a major release?

> breaking the plugin's behaviour due to refactoring What do you mean? Everything still should work as expected. With refactoring, do you mean that the Packager doesn't extend PackageTask anymore?...

I also tried settings the tasks' settings at runtime via `task.getInputs().properties(newProperties)`. But gradle ignores that, throws errors and says they are not present :/

Yeah I tried "TOJO" variant too. Gradle works fine in that case. The issue then is maven and the mojo context already bound exception. I wasnt able to figure out...

I will give implementing only the Task interface tomorrow a try.

![image](https://user-images.githubusercontent.com/59899645/186104488-9f7d2621-860e-408e-a451-090bee344ea5.png) Tried implementing only the Task, but that also fails with a class cast exception at the line above: at org.gradle.api.internal.project.taskfactory.TaskFactory.create(TaskFactory.java:79) As you can see, it specifically requires the class...

I got a question about these in my gradle task: ![image](https://user-images.githubusercontent.com/59899645/186105922-e89e4111-d2e2-42ed-9cb5-b89f03891689.png) Didnt quite understand what closures are and why they are necessary. Not sure if it works right now, since...

Well since we now got a lot of stuff simplified you could, easily duplicate the GradlePackageTask for example, rename it to GradleCreateDmgTask, and then register it in the PackagePlugin class....

> I think it's not clear ... should those closures be inside javapackager extension? Well they don't really need to, I think it would make the refactoring for users easier...