JSONP icon indicating copy to clipboard operation
JSONP copied to clipboard

Published 20 hours ago • verified publisher icon OscarGodson

Rewrite to use Promises

Open 16patsle opened this issue 9 years ago • 4 comments

Added Promises as an option instead of callbacks. Compatible with IE through polyfills. I havent made a minified version because I didn't know which tool was used. The approach to integrate Promises may not be the best available. If so I appreaciate support.

16patsle avatar Jan 09 '16 18:01 16patsle

I love the idea behind this :thumbsup:

I want to handle the minification first as part of the project, so that this ceases to be an issue to future contributions and then I'm going to review and most likely merge your PR.

carvefx avatar Jan 11 '16 10:01 carvefx

Good to hear. Really glad I can help. If you find any issues with my PR I will try my best to fix them.

16patsle avatar Jan 11 '16 15:01 16patsle

Any updates yet? It seems like there is some conflicts that needs to be resolved, so I will try to fix them as soon as I have time.

16patsle avatar Aug 16 '16 11:08 16patsle

@carvefx I have fixed some conflicts regarding the readme, so it should be ready now.

16patsle avatar Jul 28 '17 10:07 16patsle