EpicEditor
EpicEditor copied to clipboard
Made callbacks optionnal
Made callbacks optional thus it will avoid some errors or bugs
Thanks! A few things:
- Our style is to do
callback = callback || function () {}
at the beginning of the functions. Could you do that instead, or, at the least add curlys around those. We always add curlys in our codebase. - Do all tests pass? While this is not required, it'd rock if you added simple test cases for this (if callback is omitted, an error is NOT thrown)
- Whenever you're done with 1 and 2 please build (jake build to build manually or jake watch to build while editing)
Seems @vinz243 has removed his original PR branch. I can take a look into refactoring the code and adding tests, unless he's still interested?