EpicEditor icon indicating copy to clipboard operation
EpicEditor copied to clipboard

Made callbacks optionnal

Open vinz243 opened this issue 10 years ago • 2 comments

Made callbacks optional thus it will avoid some errors or bugs

vinz243 avatar Oct 12 '13 08:10 vinz243

Thanks! A few things:

  1. Our style is to do callback = callback || function () {} at the beginning of the functions. Could you do that instead, or, at the least add curlys around those. We always add curlys in our codebase.
  2. Do all tests pass? While this is not required, it'd rock if you added simple test cases for this (if callback is omitted, an error is NOT thrown)
  3. Whenever you're done with 1 and 2 please build (jake build to build manually or jake watch to build while editing)

OscarGodson avatar Oct 12 '13 08:10 OscarGodson

Seems @vinz243 has removed his original PR branch. I can take a look into refactoring the code and adding tests, unless he's still interested?

zethussuen avatar Apr 15 '15 16:04 zethussuen