Netherite-Plus-Mod icon indicating copy to clipboard operation
Netherite-Plus-Mod copied to clipboard

Fix build script, fix shulker boxes, add shields

Open Roadhog360 opened this issue 1 year ago • 6 comments

Now correct sound, rotation fixed

Roadhog360 avatar Jun 25 '24 20:06 Roadhog360

Might revert Quilt to 0.26.0, beta version seems unnecessary

Roadhog360 avatar Jun 25 '24 23:06 Roadhog360

Feel free to ask me to remove the self-attribution upon request, these changes are ultimately small so I'd understand.

Roadhog360 avatar Jun 26 '24 06:06 Roadhog360

I'm also going to add ELYTRA back to Multi-Item-Lib as the Netherite Elytra registered as an elytra is causing a few issues, like cape still rendering and other checks for elytra failing. I'll fix this in MIL. I can make another PR for this and the MIL version bump if you push MIL to your maven

Roadhog360 avatar Jun 26 '24 08:06 Roadhog360

So I decided to temporarily place MIL in libs and load it as a jar dependency so you don't need to do any manual work to test the new changes. So all you need to do if you accept the changes, is to simply change the buildscript to use the maven again and delete the jar. I can do this from my end if you want, just pull 1.6.3 MIL into your Maven and lmk to fix the dep setup

Roadhog360 avatar Jun 27 '24 21:06 Roadhog360

I didn't notice you reviewed. I'll read soon, give me a day or two.

Roadhog360 avatar Jul 06 '24 10:07 Roadhog360

I finished the review 5 days ago put forgot to actually send it.

OroArmor avatar Jul 06 '24 19:07 OroArmor