origin-js icon indicating copy to clipboard operation
origin-js copied to clipboard

Marketplace offer status could wrongly return buyerReviewed

Open DanielVF opened this issue 5 years ago • 0 comments

"OfferData" events can be posted at any time, with any data.

However, if getListing sees that an OfferData event has happened on a listing, it automatically marks the offer status as if it was finalized and a review has happened.

Code here:

https://github.com/OriginProtocol/origin-js/blob/c3de7c423fc7d0ca393cc45b3ccdc783de754a8c/src/adapters/v00/marketplace_adapter.js#L183

DanielVF avatar Sep 03 '18 14:09 DanielVF