origin-js icon indicating copy to clipboard operation
origin-js copied to clipboard

Specify node versions in package.json for origin-js and origin-dapp

Open wanderingstan opened this issue 5 years ago • 5 comments

In debugging this release, @jordajm and I noticed that we are specifying a node version in origin-js (here) but not origin-dapp.

  1. We should be specifying a node version to remove surprises on heroku (and elsewhere) when default versions are changed.
  2. We should have some discussion around which version to use. @jordajm recommends using LTS, currently 8.11, but will changing to 10.x in October.

@micahalcorn @nick , thoughts?

wanderingstan avatar Aug 13 '18 21:08 wanderingstan

If I recall correctly, our stuff does not work with 10.x so we should probably recommend 8.something.

micahalcorn avatar Aug 13 '18 21:08 micahalcorn

10.x doesn't work (I think due to js-ipfs and its dependencies, might need updating?). We use 9.x for origin-box for both origin-dapp and origin-js and they work fine. I can just update origin-box to use 8.x if we go with that though.

tomlinton avatar Aug 13 '18 21:08 tomlinton

I've been using 8.5.0 since February 2nd with no issues. ☺️

micahalcorn avatar Aug 13 '18 21:08 micahalcorn

Seems like we should switch to 10.x before October if that's the new LTS but if there's a dependency holding that up then 8.x is probably fine for now. My vote is for whatever works that's not deprecated 🙂

nick avatar Aug 14 '18 08:08 nick

I got curious so tested out 10.x in origin-box. It looks like origin-dapp is fine and origin-js just needs one dependency updated. I could put together a PR if we want to go to 10.x. No time like the present right?

tomlinton avatar Aug 15 '18 04:08 tomlinton