origin-dollar icon indicating copy to clipboard operation
origin-dollar copied to clipboard

WIP TryLSD strategy

Open naddison36 opened this issue 2 years ago • 2 comments

If you made a contract change, make sure to complete the checklist below before merging it in master.

Refer to our documentation for more details about contract security best practices.

Contract change checklist:

  • [ ] Code reviewed by 2 reviewers.
  • [ ] Copy & paste code review security checklist below this checklist.
  • [ ] Unit tests pass
  • [ ] Slither tests pass with no warning
  • [ ] Echidna tests pass if PR includes changes to OUSD contract (not automated, run manually on local)

naddison36 avatar Nov 06 '23 12:11 naddison36

Warnings
:warning: :eyes: This PR needs at least 2 reviewers

Generated by :no_entry_sign: dangerJS against 7c374d341be0aab932933013a182cd04706164dd

github-actions[bot] avatar Nov 06 '23 12:11 github-actions[bot]

Codecov Report

Attention: 161 lines in your changes are missing coverage. Please review.

Comparison is base (3f367ae) 69.31% compared to head (7c374d3) 64.68%.

Files Patch % Lines
...acts/contracts/strategies/ConvexCryptoStrategy.sol 0.00% 140 Missing :warning:
...ontracts/strategies/curve/CurveCryptoFunctions.sol 0.00% 21 Missing :warning:
Additional details and impacted files
@@                 Coverage Diff                  @@
##           nicka/amo-frxeth    #1911      +/-   ##
====================================================
- Coverage             69.31%   64.68%   -4.64%     
====================================================
  Files                    64       66       +2     
  Lines                  3155     3319     +164     
  Branches                786      825      +39     
====================================================
- Hits                   2187     2147      -40     
- Misses                  965     1169     +204     
  Partials                  3        3              

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Nov 08 '23 08:11 codecov[bot]

Closing as not longer being done

naddison36 avatar May 20 '24 04:05 naddison36