origin-dollar Renamed Vault functions and events with Ousd in them

This is an optional addition to the PR https://github.com/OriginProtocol/origin-dollar/pull/1627 that refactors the vaults

It does more more of the items in https://github.com/OriginProtocol/origin-dollar/issues/1533 Specifically, it covers removing Ousd from function names and events.

setOusdMetaStrategy -> setMetaStrategy
setNetOusdMintForStrategyThreshold -> setNetMintForStrategyThreshold
OusdMetaStrategyUpdated -> MetaStrategyUpdated
NetOusdMintForStrategyThresholdChanged -> NetMintForStrategyThresholdChanged

The two functions and corresponding events are only used by the governor so breaking the ABI is not such a big deal

Jun 15 '23 03:06 naddison36

I'd rather do these changes, later after the current OETH vault deploy

Jun 15 '23 19:06 DanielVF

@naddison36 do we want to pair this PR with deployment of some other Vault functionality? So we don't kick off the Vault deploys just for the naming changes?

Jul 06 '23 12:07 sparrowDom

Maybe it'b be cool to have a list of PRs that are waiting to join some other more impactful functionality to be deployed

Jul 06 '23 12:07 sparrowDom

For the OETH Vault, I'd say it's best to pair with something else. For the OUSD Vault, we need to decide if we include with 052_upgrade_ousd_vault_harvester or do after. I'm not set on either way but I'd lean toward doing after so both OETH and OUSD are on the same codebase.

Jul 07 '23 02:07 naddison36

Yes agreed, rolling them out for both protocols simultaneously would be nice - in respect of not complicating our environments and mental load.

Jul 07 '23 11:07 sparrowDom