dshop icon indicating copy to clipboard operation
dshop copied to clipboard

Remove domain from shop_deployments table

Open mikeshultz opened this issue 5 years ago • 2 comments

After the changes from #80 "settle" and we're happy everything is working, remove the domain column from the shop_deployments table.

mikeshultz avatar Jun 19 '20 17:06 mikeshultz

Hi @mikeshultz

From a brief study of changes to the codebase from this point in its history, I'm led to believe that there might be a connection between the deletion of the table shop_deployment_names (https://github.com/OriginProtocol/dshop/pull/765), its replacement with the table shop_domains, and the issue titled "ogn.app domain conflicts".

With shop admins being asked to migrate to alternate domains by Nov 10th, do you think that it is time to re-visit this issue?

phyninja avatar Nov 05 '21 11:11 phyninja

@mikeshultz I haven't heard back from you in response to

With shop admins being asked to migrate to alternate domains by Nov 10th, do you think that it is time to re-visit this issue?

The PR linked to this issue addresses your original statement. Could you please take a look?

phyninja avatar Nov 26 '21 10:11 phyninja