Ori Hoch
Ori Hoch
* should use the travis [Build Matrix](https://docs.travis-ci.com/user/customizing-the-build/#Build-Matrix) feature to run the tests on all supported database engines * I guess it means sqlite and PostgreSQL, but maybe we could add...
### reproduction steps * use dump.to_sql with a field defined as `date` * when dump.to_sql is run it will create the table and defined the column as a date type...
currently CORS configuration is defined globally using regex of paths: https://github.com/hasadna/anyway/blob/dev/anyway/app_and_db.py#L30 This is problematic for these reasons: * security configurations should be defined as close as possible to the relevant...
Following are some suggestions for ETL / Airflow improvements, need to decide which improvement to do / by who and split to separate tasks: * CBS: Add dev helper task...
https://dev-airflow.anyway.co.il/log?dag_id=process-news-flash&task_id=process-news-flash&execution_date=2021-10-11T06%3A00%3A00%2B00%3A00 ``` [2021-10-11 06:30:41,286] {bash.py:173} INFO - ERROR:root:exception caught while extracting geocode location for: "כביש 6, סמוך למחלף אייל" [2021-10-11 06:30:41,286] {bash.py:173} INFO - Traceback (most recent call last): [2021-10-11...
according to this document (cbs etl section): https://docs.google.com/document/d/1LirLg1u7B3ekvcjetj6LhVExijVqctMZ83fJHUYzlrI/edit#heading=h.rxg36ie7m1yr also, deploy an Airflow server to run this etl process
to improve ease of use and development on anyway-etl some documentation improvements could be done, see suggestions for improvements in following comments: * https://github.com/hasadna/anyway/pull/1872#discussion_r688975634 * https://github.com/hasadna/anyway/pull/1872#discussion_r688977179 * https://github.com/hasadna/anyway/pull/1872#discussion_r688977335
following the change in #1872 we want to reduce dependencies between module imports please see the following comments on that PR for suggested improvements: * https://github.com/hasadna/anyway/pull/1872/files/58895b6a8cd040a4954c7bc9d14208927f49278a#r689008963 * https://github.com/hasadna/anyway/pull/1872/files/58895b6a8cd040a4954c7bc9d14208927f49278a#r689008209 * https://github.com/hasadna/anyway/pull/1872/files/58895b6a8cd040a4954c7bc9d14208927f49278a#r689008450...
* see updated README for description of this feature: https://github.com/OriHoch/guidance/blob/add-openai-usage-and-cost-tracking/README.md#openai-usage-and-cost-tracking * added unit test