orfium-ictinus icon indicating copy to clipboard operation
orfium-ictinus copied to clipboard

Overlapping CSS rules in Select.style and TextInputBase.style

Open mkarajohn opened this issue 3 years ago • 1 comments

These style rules in Select.style apply the same visuals as these rules from TextInputBase.style.

Since TextInputBase is a building component of Select the Select.style rule seems to be a leftover. It is also more error prone because it targets a child element on which it applies the rule, while the TextInputBase.style rule targets the element in question directly and is also a better solution since it simply uses the :focus-within selector.

If it's confirmed that both rules are not needed we should go ahead and remove the one from Select

cc @Christos-Zacharopoulos @panvourtsis @whosyourtaco since you are the contributors to these lines.

mkarajohn avatar Jan 07 '22 06:01 mkarajohn

This, along with others, will be resolved in the global states ticket.

tentascoding avatar Jan 07 '22 08:01 tentascoding

I think the above links are no longer valid. Is that true? @mkarajohn

panvourtsis avatar Mar 14 '23 08:03 panvourtsis