Orfeas Zafeiris

Results 126 comments of Orfeas Zafeiris

We're hitting the same issue, affecting ~1 in 10 users. We also have no reliable way to reproduce it so we're currently looking into automating the behavior the seems to...

TSAN immediately reports the following: ``` WARNING: ThreadSanitizer: data race (pid=6112) Read of size 8 at 0x00010d109c18 by main thread (mutexes: write M0): #0 facebook::react::ShadowNode::clone(facebook::react::ShadowNodeFragment const&) const (app:arm64+0x10048c5a8) #1 reanimated::cloneShadowTreeWithNewPropsRecursive(facebook::react::ShadowNode...

From looking at this, it seems that thread T9 is writing into `family.nativeProps_DEPRECATED` while reanimated is cloning the shadow tree, resulting in a data race inside `ShadowNode::clone`, which tries to...

After some further investigation, the call to `setNativeProps` _seems_ to come from react-native itself, and more specifically `node_modules/react-native/src/private/animated/createAnimatedPropsHook.js`. No luck creating a repro yet...

TSan reports two additional data races: ``` ================== WARNING: ThreadSanitizer: data race (pid=80367) Write of size 8 at 0x000125611330 by thread T11 (mutexes: write M0): #0 std::__1::shared_ptr::operator=[abi:ne180100](std::__1::shared_ptr const&) (app:arm64+0x1000b539c) #1...

For now, due to lack of a better options, we've applied the following patch to react-native, hoping it improves the situation. We'll monitor and I'll post an update here. Keep...

We haven't seen any additional crashes since this patch was deployed, so it seems to be working. Not sure what next steps for this would be? Try to upstream on...

After over a month in production with this patch, I can now confirm that this crash no longer occurs. However, the react-native team has not even looked at the PR....

> Thank you [@OrfeasZ](https://github.com/OrfeasZ) and [@piaskowyk](https://github.com/piaskowyk)! > > I have been monitoring it for a while, and I'm also seeing this happening in the latest version of React Native and...

Looks like this issue also affects fable `4.26.0` (I know it's unlisted, and not expecting any support, but thought I'd mention this here in case it provides any insight). Getting...